Skip to content

test: migrate some snapshots from python to js#57778

Open
bjohansebas wants to merge 4 commits intonodejs:mainfrom
bjohansebas:test-python
Open

test: migrate some snapshots from python to js#57778
bjohansebas wants to merge 4 commits intonodejs:mainfrom
bjohansebas:test-python

Conversation

@bjohansebas
Copy link
Copy Markdown
Member

@bjohansebas bjohansebas commented Apr 6, 2025

There’s still one test failing related to this PR, but with this PR we should have migrated all the tests in /test/message to use Node.js' built-in snapshots

ref #47707

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 6, 2025
Comment thread test/fixtures/errors/util_inspect_error_cause.snapshot Outdated
@bjohansebas bjohansebas changed the title test: migrate snapshots from python to js test: migrate some snapshots from python to js May 30, 2025
@bjohansebas bjohansebas marked this pull request as ready for review May 30, 2025 21:33
@codecov
Copy link
Copy Markdown

codecov Bot commented May 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.23%. Comparing base (9524908) to head (d6aea7f).
⚠️ Report is 2233 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57778      +/-   ##
==========================================
- Coverage   90.25%   90.23%   -0.02%     
==========================================
  Files         635      635              
  Lines      187635   187635              
  Branches    36861    36863       +2     
==========================================
- Hits       169347   169315      -32     
- Misses      11055    11099      +44     
+ Partials     7233     7221      -12     

see 34 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bjohansebas bjohansebas added the review wanted PRs that need reviews. label Jun 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-ci PRs that need a full CI run. review wanted PRs that need reviews. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants