test: migrate some snapshots from python to js#57778
Open
bjohansebas wants to merge 4 commits intonodejs:mainfrom
Open
test: migrate some snapshots from python to js#57778bjohansebas wants to merge 4 commits intonodejs:mainfrom
bjohansebas wants to merge 4 commits intonodejs:mainfrom
Conversation
bjohansebas
commented
Apr 7, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #57778 +/- ##
==========================================
- Coverage 90.25% 90.23% -0.02%
==========================================
Files 635 635
Lines 187635 187635
Branches 36861 36863 +2
==========================================
- Hits 169347 169315 -32
- Misses 11055 11099 +44
+ Partials 7233 7221 -12 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There’s still one test failing related to this PR, but with this PR we should have migrated all the tests in/test/messageto use Node.js' built-in snapshotsref #47707