Skip to content

lib: Know when a process ended due to the child_process.spawn() timeout option #51561 #51608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FranciscoMateusVG wants to merge 3 commits into
base: main
Choose a base branch
from
Open

lib: Know when a process ended due to the child_process.spawn() timeout option #51561 #51608

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
51766b0
lib: add timedOut flag on child process spawn
FranciscoMateusVG Jan 30, 2024
0b1f813
test: add test for checking timedOut flag is set on child process spawn
FranciscoMateusVG Jan 30, 2024
2e3cb97
doc: add API docs for subprocess.timedOut property
FranciscoMateusVG Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lib/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -764,6 +764,7 @@ function spawn(file, args, options) {
let timeoutId = setTimeout(() => {
if (timeoutId) {
try {
child.timedOut = true;
child.kill(killSignal);
} catch (err) {
child.emit('error', err);
Expand Down
1 change: 1 addition & 0 deletions lib/internal/child_process.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ function ChildProcess() {
this.exitCode = null;
this.killed = false;
this.spawnfile = null;
this.timedOut = false;

this._handle = new Process();
this._handle[owner_symbol] = this;
Expand Down
11 changes: 11 additions & 0 deletions test/parallel/test-child-process-spawn-timeout-kill-signal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,17 @@ const aliveForeverFile = 'child-process-stay-alive-forever.js';
}), /ERR_OUT_OF_RANGE/);
}

{
// Verify timedOut flag is set true
const cp = spawn(process.execPath, [fixtures.path(aliveForeverFile)], {
timeout: 6,
});
strictEqual(cp.timedOut, false);
cp.on('exit', mustCall(() => {
strictEqual(cp.timedOut, true);
}));
}

{
// Verify abort signal gets unregistered
const controller = new AbortController();
Expand Down