Skip to content

fix: disable wasm highlighter on riscv64 #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivkeller merged 3 commits into from
Mar 23, 2026
Merged

fix: disable wasm highlighter on riscv64 #691

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6960c15
fix: disable wasm highlighter on riscv64
kxxt Mar 21, 2026
de9922a
fix: enable wasm highlighter for s390x
kxxt Mar 21, 2026
2ce69e3
fix: limit threads to 1 on riscv64
kxxt Mar 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/utils/highlighter.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,11 @@ function isCodeBlock(node) {
export const highlighter = await createHighlighter({
// s390x machines throw memory issues on WASM builds
// https://github.com/nodejs/node/blob/c9acf345922bd758fbb3f16ee6256aa165260219/test/common/sea.js#L55
wasm: process.arch !== 's390x',
//
// riscv64 with sv39 has limited virtual memory space, where creating
// too many (>20) wasm memory instances fails.
// https://github.com/nodejs/node/pull/60591
wasm: !['riscv64', 's390x'].includes(process.arch),
Comment thread
kxxt marked this conversation as resolved.
Outdated
});

/**
Expand Down
Loading