Skip to content

restrict AIX use of clang to 26+ instead of 25+ #4307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sxa merged 2 commits into from
Apr 22, 2026
+9 −6
Merged

restrict AIX use of clang to 26+ instead of 25+ #4307

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
52ecd45
restrict AIX use of clang to 26+ instead of 25+
sxa Apr 22, 2026
bbc585f
fixup logic
sxa Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions jenkins/scripts/select-compiler.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,11 +37,14 @@ fi
if [ "$NODEJS_MAJOR_VERSION" -ge "25" ]; then
case $NODE_NAME in
*aix*)
echo "Using Clang for Node.js $NODEJS_MAJOR_VERSION"
export PATH="/opt/ccache-3.7.4/libexec:/opt/clang+llvm-20.1.7-powerpc64-ibm-aix-7.2/bin/:$PATH"
export CC="clang"
export CXX="clang++"
echo "Compiler set to Clang" `${CXX} -dumpversion`
# AIX does not support building v25 with clang so restrict to >25
if [ "$NODEJS_MAJOR_VERSION" -ge "26" ]; then
echo "Using Clang for Node.js $NODEJS_MAJOR_VERSION"
export PATH="/opt/ccache-3.7.4/libexec:/opt/clang+llvm-20.1.7-powerpc64-ibm-aix-7.2/bin/:$PATH"
export CC="clang"
export CXX="clang++"
echo "Compiler set to Clang" `${CXX} -dumpversion`
fi
return
Copy link
Copy Markdown
Member

@richardlau richardlau Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may need the return to be inside the if block for the fall through to work as expected.

Copy link
Copy Markdown
Member Author

@sxa sxa Apr 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

;;
*fedora*)
Expand Down