post new learn resources about "package publish"#44
post new learn resources about "package publish"#44joyeecheung merged 7 commits intonodejs:mainfrom AugustinMauroy:publish
Conversation
|
Is "We gotchu" too colloquial (difficult for ESL users)? Should it be "We got you"? |
Any strong opinion on that. Because blue sky have an integrated translation feature (google translate) and I had test with "we gotchu" and it's translate correctly. And also I think we need to be familiar instead of corporate |
Sweet! Looks like no problem then 😃 |
There was a problem hiding this comment.
From the guidelines https://github.com/nodejs/bluesky/blob/main/review_guidelines.md it seems only release annoucements are allowed. Let me check if documentation needs to be updated. (I see other things have been reposted so apparently the documentation is wrong)
Apparently its ok to repost articles
I didn't know this either, and have been asking for many reposts. agree we should update |
|
@nodejs/bluesky can we process for this pr ? |
|
re ping @nodejs/bluesky |
|
The article itself doesn't seem to be ready as a definitive guide for package publishing, I've seem some package maintainers discussing the usage of exports field for various special needs outside what's described in that article (e.g. patterns used by https://github.com/privatenumber/pkgroll). It would be better to be sent as an invitation for further improvement on this guide instead of saying "we gotchu" which implies it's everything you will need. |
That is a good point: it is not in its final form (ex 2 items down my todo list is splitting this article into 2: basic and exotic configs). Happy to re-word. |
|
Does the new wording change it much? I feel that it would be more apt to say something like "we have started working on this guide, com join us improving it", to make it clearer that it's not complete. |
|
How about
|
|
Generally LGTM though I think
can probably be tweaked to
to be more actionable (does it fit in 300 chars?) |
|
Sounds good to me. I'll try to get it to fit |
|
Any news ? Do we still need a post for that ? |
|
I think it's just pending an update based on #44 (comment)? |
Co-authored-by: Jacob Smith <[email protected]>
Co-authored-by: Jacob Smith <[email protected]>
|
cc @joyeecheung |
Co-authored-by: Joyee Cheung <[email protected]>
JakobJingleheimer
left a comment
There was a problem hiding this comment.
Ack. I didn't open this, so it wasn't listed in my PRs so I forgot about it. Thanks Augustin and Joyee!
joyeecheung
left a comment
There was a problem hiding this comment.
LGTM though it seems missing a punctuation
#36