Conversation
5d576f8 to
e2dca8b
Compare
a6d8a67 to
8bc0fb6
Compare
- Bump supported Ubuntu range to 24.04 - 26.04 (Resolute Raccoon) - PHP 8.3 -> 8.5, PostgreSQL 16 -> 18 (defaults on 26.04) - Centralize version checks in lib.sh: SUPPORTED_VERSION_MIN/MAX, LATEST_VERSION (derived), SUPPORTED_CODENAMES β single source of truth - Make check_php() fully dynamic (regex on `php -v`, /etc/php fallback) - Replace hardcoded stop_if_installed lists with brace-expansion loops covering php7.0-7.9, php8.0-8.9 and postgresql-9.x through postgresql-30 Signed-off-by: enoch85 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
lib.sh(SUPPORTED_VERSION_MIN/MAX,LATEST_VERSIONderived,SUPPORTED_CODENAMES) so the next bump is a 3-line editcheck_php()fully dynamic (regex onphp -v,/etc/phpfallback)stop_if_installedlists with brace-expansion loopspython2fromapps/webmin.sh(no install candidate on 26.04, no longer required by Webmin)External source / dependency audit
apps/webmin.shsarge contribsuite β codename-independent. Works on any Debian/Ubuntuapps/talk.sh:137${CODENAME} == "jammy"only β already no-op on noble/resolute.coturnis then installed from Ubuntu's own repoapps/talk.sh:351bionic|focalβ no-op on resolute.janusfrom Ubuntu's own repoapps/talk.sh:301nats mainβ codename-agnosticapps/talk.sh:374signaling mainβ codename-agnosticmigrate/docker/migrate.sh:56$(lsb_release -cs)-pgdgβ auto-picksresolute-pgdgresolutedistro (typically within weeks of LTS release). Only used by the docker-migration helper, low trafficnetwork/geoblock.sh:88lib.sh:1902(get.docker.com)apps/netdata.sh:66(get.netdata.cloud)network/geoblock.sh:107lib.sh,apps/bpytop.shapps/webmin.sh:85webmin_2.010_all.deb(sourceforge) β distro-agnosticpython2apps/webmin.sh:55apps/imaginary.sh:82is_this_installedremoval guard, skipped on fresh installspostgresqlmeta-packageredis-serverrequirepass+ unix socket setupzfsutils-linuxTest plan
bash -non all 17 modified scriptsshellcheck(repo CI flags) β zero warningslib.shin real Ubuntu 26.04 container β variables resolve,version()/check_distro_version()/check_php()pass positive and negative testspython2not installable on 26.04 β fix includednats-server+spreed-signalingupstream availability)