security concerns: adding password placeholders instead of a value, a…

aws/deploy_and_config/simple_lb/variables.tf

@@ -40,6 +40,7 @@ variable "aws_access_key" {
 
 variable "aws_secret_key" {
   description = "The AWS secret key"
+  sensitive   = true
 }
 
 # Citrix ADC Provider Configuration

aws/deploy_and_config/simple_lb_across_az/variables.tf

@@ -40,6 +40,7 @@ variable "aws_access_key" {
 
 variable "aws_secret_key" {
   description = "The AWS secret key"
+  sensitive   = true
 }
 
 # Citrix ADC Provider Configuration

aws/deployments/cloud_native/cic_deployment/variable.tf

@@ -4,6 +4,7 @@ variable "adc_login_secret_name" {
 
 variable "new_password" {
     description = "Provide the New Password for Citrix ADC"
+    sensitive   = true
 }
 
 variable "cic_config_snip" {

aws/deployments/cloud_native/citrix_adc_variables.tf

@@ -91,4 +91,5 @@ variable "reset_password" {
 
 variable "new_password" {
   description = "The new ADC password that will replace the default one on both ADC instances. Applicable only when reset_password variable is set to `true`"
+  sensitive   = true
 }

aws/deployments/cloud_native/variables.tf

@@ -34,10 +34,12 @@ variable "aws_region" {
 
 variable "aws_access_key" {
   description = "The AWS access key"
+  sensitive   = true
 }
 
 variable "aws_secret_key" {
   description = "The AWS secret key"
+  sensitive   = true
 }
 
 variable "naming_prefix" {

aws/deployments/ha_across_az/for_external_apps/example.tfvars

@@ -11,8 +11,8 @@ new_keypair_required             = true
 aws_ssh_keypair_name             = "test-keypair-ap-southeast-1" # If the above `new_keypair_required` is `false`, then this keypair name should be existing in the `aws_region`
 ssh_public_key_filename          = "~/.ssh/test.pub"
 citrixadc_management_access_cidr = "11.11.0.0/16"
-citrixadc_management_password    = "verystrongpassword"
-citrixadc_rpc_node_password      = "newrpcnodepassword"
+citrixadc_management_password    = "<<enter password>>"
+citrixadc_rpc_node_password      = "<<enter password>>"
 citrixadc_instance_type          = "m5.xlarge"
 citrixadc_product_name           = "Citrix ADC VPX - Customer Licensed"
 citrixadc_product_version        = "13.1"

aws/deployments/ha_across_az/for_external_apps/variables.tf

@@ -63,10 +63,12 @@ variable "ssh_public_key_filename" {
 variable "citrixadc_management_password" {
   type        = string
   description = "The new ADC password that will replace the default one on both ADC instances."
+  sensitive   = true
 }
 
 variable "citrixadc_rpc_node_password" {
   type        = string
+  sensitive   = true
   description = "The new ADC RPC node password that will replace the default one on both ADC instances. [Learn More about RPCNode](https://docs.citrix.com/en-us/citrix-adc/current-release/getting-started-with-citrix-adc/change-rpc-node-password.html)"
 }
 

aws/deployments/ha_across_az/for_internal_apps/example.tfvars

@@ -11,8 +11,8 @@ new_keypair_required             = true
 aws_ssh_keypair_name             = "test-keypair-ap-southeast-1" # If the above `new_keypair_required` is `false`, then this keypair name should be existing in the `aws_region`
 ssh_public_key_filename          = "~/.ssh/test.pub"
 citrixadc_management_access_cidr = "11.11.0.0/16"
-citrixadc_management_password    = "verystrongpassword"
-citrixadc_rpc_node_password      = "newrpcnodepassword"
+citrixadc_management_password    = "<<enter password>>"
+citrixadc_rpc_node_password      = "<<enter password>>"
 citrixadc_instance_type          = "m5.xlarge"
 citrixadc_product_name           = "Citrix ADC VPX - Customer Licensed"
 citrixadc_product_version        = "13.1"

aws/deployments/ha_across_az/for_internal_apps/variables.tf

@@ -62,11 +62,13 @@ variable "ssh_public_key_filename" {
 
 variable "citrixadc_management_password" {
   type        = string
+  sensitive   = true
   description = "The new ADC password that will replace the default one on both ADC instances."
 }
 
 variable "citrixadc_rpc_node_password" {
   type        = string
+  sensitive   = true
   description = "The new ADC RPC node password that will replace the default one on both ADC instances. [Learn More about RPCNode](https://docs.citrix.com/en-us/citrix-adc/current-release/getting-started-with-citrix-adc/change-rpc-node-password.html)"
 }
 

aws/deployments/ha_across_az/ha_across_az_prerequisites/variables.tf

@@ -43,4 +43,5 @@ variable "aws_access_key" {
 
 variable "aws_secret_key" {
   description = "The AWS secret key"
+  sensitive   = true
 }

aws/deployments/ha_same_az/ha_same_az_new_deployment/example.tfvars

@@ -10,8 +10,8 @@ new_keypair_required             = true
 aws_ssh_keypair_name             = "test-keypair-ap-southeast-1" # If the above `new_keypair_required` is `false`, then this keypair name should be existing in the `aws_region`
 ssh_public_key_filename          = "~/.ssh/test.pub"
 citrixadc_management_access_cidr = "15.10.0.0/16"
-citrixadc_management_password    = "verystrongpassword"
-citrixadc_rpc_node_password      = "newrpcnodepassword"
+citrixadc_management_password    = "<<enter password>>"
+citrixadc_rpc_node_password      = "<<enter password>>"
 citrixadc_instance_type          = "m5.xlarge"
 citrixadc_product_version        = "13.1"
 citrixadc_product_name           = "Citrix ADC VPX - Customer Licensed"

aws/deployments/ha_same_az/ha_same_az_new_deployment/variables.tf

@@ -56,11 +56,13 @@ variable "citrixadc_instance_type" {
 
 variable "citrixadc_management_password" {
   type = string
+  sensitive   = true
   description = "The new ADC password that will replace the default one on both ADC instances."
 }
 
 variable "citrixadc_rpc_node_password" {
   type = string
+  sensitive   = true
   description = "The new ADC RPC node password that will replace the default one on both ADC instances. [Learn More about RPCNode](https://docs.citrix.com/en-us/citrix-adc/current-release/getting-started-with-citrix-adc/change-rpc-node-password.html)"
 }
 

aws/deployments/standalone_3nic/standalone_3nic_new_deployment/provider_variables.tf

@@ -38,8 +38,10 @@ variable "aws_availability_zone" {
 
 variable "aws_access_key" {
   description = "The AWS access key"
+  sensitive   = true
 }
 
 variable "aws_secret_key" {
   description = "The AWS secret key"
+  sensitive   = true
 }

aws/deployments/standalone_3nic/standalone_3nic_prerequisites/provider_variables.tf

@@ -38,8 +38,10 @@ variable "aws_availability_zone" {
 
 variable "aws_access_key" {
   description = "The AWS access key"
+  sensitive   = true
 }
 
 variable "aws_secret_key" {
   description = "The AWS secret key"
+  sensitive   = true
 }

aws/modules/aws_citrixadc/variables.tf

@@ -35,6 +35,7 @@ variable "aws_access_key" {
 
 variable "aws_secret_key" {
   type        = string
+  sensitive   = true
   description = "The AWS secret key. This can also be given as the environment variable `TF_VAR_aws_secret_key`."
 }
 

azure/deploy_and_config/simple_lb/variables.tf

@@ -58,5 +58,6 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }

azure/deploy_and_config/simple_lb_ha/variables.tf

@@ -58,6 +58,7 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 

azure/deployments/cloud_native/azure_internal_lb_nsip/variables.tf

@@ -29,6 +29,7 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 

azure/deployments/cloud_native/azure_route_table/variable.tf

@@ -63,6 +63,7 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 

azure/deployments/cloud_native/variables.tf

@@ -37,6 +37,7 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 

azure/deployments/deploy_adm_agent/examples.tfvars

@@ -16,7 +16,7 @@ adm_agent_version_offer = "netscaler-ma-service-agent"
 
 # Don't use `nsroot` or `admin` as the username
 adm_agent_admin_username = "agent"
-adm_agent_admin_password = "Verysecret@123"
+adm_agent_admin_password = "<<enter password>>"
 
 admin_ip_address = "10.10.10.10" #  This ip address will have SSH permission to Manage ADM Agent
 

azure/deployments/deploy_adm_agent/variables.tf

@@ -41,6 +41,7 @@ variable "adm_agent_admin_username" {
   default     = "agent"
 }
 variable "adm_agent_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 variable "admin_ip_address" {

azure/deployments/deploy_adm_agent_on_existing_vnet/variables.tf

@@ -34,6 +34,7 @@ variable "adm_agent_admin_username" {
   default     = "agent"
 }
 variable "adm_agent_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 variable "admin_ip_address" {

azure/deployments/ha_availability_set/examples.tfvars

@@ -4,7 +4,7 @@ management_subnet_address_prefix = "10.0.1.0/24"
 client_subnet_address_prefix = "10.0.2.0/24"
 server_subnet_address_prefix = "10.0.3.0/24"
 
-citrixadc_rpc_node_password = "Secret@12345"
-adc_admin_password = "Verysecret@123"
+citrixadc_rpc_node_password = "<<enter password>>"
+adc_admin_password = "<<enter password>>"
 
 controlling_subnet = "10.1.0.0/16"

azure/deployments/ha_availability_set/variables.tf

@@ -29,9 +29,11 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 variable "citrixadc_rpc_node_password" {
+  sensitive   = true
   description = "The new ADC RPC node password that will replace the default one on both ADC instances. [Learn More about RPCNode](https://docs.citrix.com/en-us/citrix-adc/current-release/getting-started-with-citrix-adc/change-rpc-node-password.html)"
 }
 

azure/deployments/ha_availability_zones/examples.tfvars

@@ -4,7 +4,7 @@ client_subnet_address_prefix = "10.0.2.0/24"
 server_subnet_address_prefix = "10.0.3.0/24"
 location = "centralindia"
 
-citrixadc_rpc_node_password = "Secret@12345"
-adc_admin_password = "Verysecret@123"
+citrixadc_rpc_node_password = "<<enter password>>"
+adc_admin_password = "<<enter password>>"
 
 controlling_subnet = "10.10.10.0/24"

azure/deployments/ha_availability_zones/variables.tf

@@ -29,9 +29,11 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 variable "citrixadc_rpc_node_password" {
+  sensitive   = true
   description = "The new ADC RPC node password that will replace the default one on both ADC instances. [Learn More about RPCNode](https://docs.citrix.com/en-us/citrix-adc/current-release/getting-started-with-citrix-adc/change-rpc-node-password.html)"
 }
 

azure/deployments/ha_inc_mode/examples.tfvars

@@ -1,5 +1,5 @@
 management_subnet_address_prefix = "10.0.1.0/24"
 client_subnet_address_prefix = "10.0.2.0/24"
 
-citrixadc_rpc_node_password = "Secret@12345"
-adc_admin_password = "Verysecret@123"
+citrixadc_rpc_node_password = "<<enter password>>"
+adc_admin_password = "<<enter password>>"

azure/deployments/ha_inc_mode/variables.tf

@@ -3,6 +3,7 @@ variable "adc_admin_username" {
   default     = "nsroot"
 }
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 variable "management_subnet_address_prefix" {

azure/deployments/provision_two_vpx/examples.tfvars

@@ -4,7 +4,7 @@ management_subnet_address_prefix = "10.0.1.0/24"
 client_subnet_address_prefix = "10.0.2.0/24"
 server_subnet_address_prefix = "10.0.3.0/24"
 
-citrixadc_rpc_node_password = "Secret@12345"
-adc_admin_password = "Verysecret@123"
+citrixadc_rpc_node_password = "<<enter password>>"
+adc_admin_password = "<<enter password>>"
 
 controlling_subnet = "10.1.0.0/16"

azure/deployments/provision_two_vpx/variables.tf

@@ -29,9 +29,11 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 variable "citrixadc_rpc_node_password" {
+  sensitive   = true
   description = "The new ADC RPC node password that will replace the default one on both ADC instances. [Learn More about RPCNode](https://docs.citrix.com/en-us/citrix-adc/current-release/getting-started-with-citrix-adc/change-rpc-node-password.html)"
 }
 

azure/deployments/standalone_3nic/sample_input_variables.txt

@@ -8,5 +8,5 @@ management_subnet_address_prefix = "10.22.1.0/24"
 client_subnet_address_prefix = "10.22.2.0/24"
 server_subnet_address_prefix = "10.22.3.0/24"
 
-adc_admin_password = "VerySecret1234"
+adc_admin_password = "<<enter password>>"
 controlling_subnet = "1.2.3.4/32"

azure/deployments/standalone_3nic/variables.tf

@@ -29,6 +29,7 @@ variable "adc_admin_username" {
 }
 
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }
 

azure/deployments/standalone_3nic_on_existing_vnet/examples.tfvars

@@ -7,4 +7,4 @@ server_subnet_name = "terraform-server-subnet"
 location = "Central India"
 controlling_subnet = "1.2.3.4/32"
 
-adc_admin_password = "VerySecret1234"
+adc_admin_password = "<<enter password>>"

azure/deployments/standalone_3nic_on_existing_vnet/variables.tf

@@ -41,5 +41,6 @@ variable "adc_admin_username" {
   default     = "nsroot"
 }
 variable "adc_admin_password" {
+  sensitive   = true
   description = "Password for the Citrix ADC admin user. Must be sufficiently complex to pass azurerm provider checks."
 }

esxi/deployments/ha_noninc/examples.tfvars

@@ -1,10 +1,10 @@
 # NetScaler admin credentials
 # These should match the credentials that you want to set.
-adc_admin_password = ""
+adc_admin_password = "<<enter password>>"
 
 #NetScaler Default password
-adc_default_password = ""
+adc_default_password = "<<enter password>>"
 
 # RPC node password for secure HA communication
 # This will be set on both NetScaler nodes for secure HA synchronization
-citrixadc_rpc_node_password = ""
+citrixadc_rpc_node_password = "<<enter password>>"

esxi/deployments/provision_two_vpx/terraform.tfvars

@@ -14,7 +14,7 @@ subnetmask = "255.255.255.0"
 # vSphere/ESXi configuration
 vsphere_ip = "10.106.195.4"
 vsphere_username = "root"
-vsphere_password = "Freebsd123$%^"
+vsphere_password = "<<enter password>>"
 
 # ESXi resource details
 # For standalone ESXi, these are typically the default values

gcp/deployments/ha_pair_external_ip_additional_setup/variables.tf

@@ -44,6 +44,7 @@ variable "secondary_snip_netmask" {
 
 variable "password" {
   description = "Password for the HA pair"
+  sensitive   = true
 }
 
 variable "ipset_name" {

gcp/deployments/ha_pair_private_ip_additional_setup/variables.tf

@@ -35,6 +35,7 @@ variable "secondary_snip_netmask" {
 
 variable "password" {
   description = "Password for the HA pair"
+  sensitive   = true
 }
 
 variable "backend_service_address" {

on_prem/configure_on_prem_netscaler_adcs_in_high_availability/step1_configure_ha/example.tfvars

@@ -1,4 +1,4 @@
 netscaler1_nsip = "10.10.10.1"
 netscaler2_nsip = "10.10.10.2"
 
-rpc_node_password = "verysecretrpcnodepassword"
+rpc_node_password = "<<enter password>>"