Conversation
42c01fb to
bc666c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because
This pull request
project=local-chromiumIssue that this pull request solves
Closes: FXA-13074
Checklist
Put an
xin the boxes that applyHow to review (Optional)
Screenshots (Optional)
Please attach the screenshots of the changes made in case of change in user interface.
Other information (Optional)
It's worth noting that another option, although it was not recommended by Claude, was creating a virtual webauthn adapter that acted like a polyfil and would be added to the browser during the page initialization. The big down side to this is that we aren't actually testing a real implementation of webauthn. By using chrome here, we are at least exercising an actual implementation of the web authn spec that is running in a browser. We therefore do not have maintain our implementation, and assuming Firefox and Chrome are aligned in their implementation of webauthn, we get good / realistic test coverage.
It's possible that in the long run this doesn't hold up, and we need to generate polyfils. For example for example if we want to test sign-in to sync with a passkey, we must then use a polyfil for this flow, since it requires passing web channel messages to Firefox.