Commit 7425d67
committed
fix(cloud tasks): ignore duplicate inactive acct email task error by message
Because:
- we saw some "entity already exists" errors reported to Sentry when
creating Google Cloud Task for the second inactive account
notification email
This commit:
- updates the error detection to use the error message only
- I originally used 10 as the error code as that was what I saw in
the error during development (and still see at the time of this
patch); that value does not match the documented gRPC constant for
that type of error. But this wouldn't be the first time I've
noticed a discrepancy between the gRPC stuff and nodejs + REST.1 parent 91bda52 commit 7425d67
2 files changed
Lines changed: 2 additions & 2 deletions
File tree
- packages/fxa-auth-server
- lib/inactive-accounts
- scripts/delete-inactive-accounts
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
63 | 63 | | |
64 | 64 | | |
65 | 65 | | |
66 | | - | |
| 66 | + | |
67 | 67 | | |
68 | 68 | | |
69 | 69 | | |
| |||
Lines changed: 1 addition & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
543 | 543 | | |
544 | 544 | | |
545 | 545 | | |
546 | | - | |
| 546 | + | |
547 | 547 | | |
548 | 548 | | |
549 | 549 | | |
| |||
0 commit comments