Merge pull request #18791 from mozilla/FXA-11516

feat(payments-next): Disable glean in CI

Author: david1alvarez

libs/payments/metrics/src/lib/glean/glean.manager.spec.ts

@@ -30,7 +30,10 @@ describe('PaymentsGleanManager', () => {
   let paymentsGleanServerEventsLogger: any;
   let spyPopulateCommonMetrics: jest.SpyInstance;
 
+  const originalEnv = process.env;
+
   beforeEach(async () => {
+    process.env = { ...originalEnv, CI: '' };
     const moduleRef = await Test.createTestingModule({
       providers: [
         MockPaymentsGleanFactory,
@@ -43,6 +46,10 @@ describe('PaymentsGleanManager', () => {
     paymentsGleanServerEventsLogger = moduleRef.get(PaymentsGleanProvider);
   });
 
+  afterEach(() => {
+    process.env = originalEnv;
+  });
+
   it('should be defined', () => {
     expect(paymentsGleanManager).toBeDefined();
   });

libs/payments/metrics/src/lib/glean/glean.manager.ts

@@ -34,7 +34,7 @@ export class PaymentsGleanManager {
     cartMetricsData: CartMetrics;
     cmsMetricsData: CmsMetricsData;
   }) {
-    if (this.paymentsGleanConfig.enabled) {
+    if (this.isEnabled) {
       this.paymentsGleanServerEventsLogger.recordPaySetupView(
         this.populateCommonMetrics(metrics)
       );
@@ -46,7 +46,7 @@ export class PaymentsGleanManager {
     cartMetricsData: CartMetrics;
     cmsMetricsData: CmsMetricsData;
   }) {
-    if (this.paymentsGleanConfig.enabled) {
+    if (this.isEnabled) {
       this.paymentsGleanServerEventsLogger.recordPaySetupEngage(
         this.populateCommonMetrics(metrics)
       );
@@ -61,7 +61,7 @@ export class PaymentsGleanManager {
     },
     paymentProvider?: PaymentProvidersType
   ) {
-    if (this.paymentsGleanConfig.enabled) {
+    if (this.isEnabled) {
       this.paymentsGleanServerEventsLogger.recordPaySetupSubmit({
         ...this.populateCommonMetrics(metrics),
         subscription_payment_provider:
@@ -80,7 +80,7 @@ export class PaymentsGleanManager {
   ) {
     const commonMetrics = this.populateCommonMetrics(metrics);
 
-    if (this.paymentsGleanConfig.enabled) {
+    if (this.isEnabled) {
       this.paymentsGleanServerEventsLogger.recordPaySetupSuccess({
         ...commonMetrics,
         subscription_payment_provider:
@@ -99,7 +99,7 @@ export class PaymentsGleanManager {
   ) {
     const commonMetrics = this.populateCommonMetrics(metrics);
 
-    if (this.paymentsGleanConfig.enabled) {
+    if (this.isEnabled) {
       this.paymentsGleanServerEventsLogger.recordPaySetupFail({
         ...commonMetrics,
         subscription_payment_provider:
@@ -117,7 +117,7 @@ export class PaymentsGleanManager {
   ) {
     const commonMetrics = this.populateCommonMetrics(metrics);
 
-    if (this.paymentsGleanConfig.enabled) {
+    if (this.isEnabled) {
       this.paymentsGleanServerEventsLogger.recordSubscriptionEnded({
         ...commonMetrics,
         subscription_payment_provider:
@@ -178,4 +178,8 @@ export class PaymentsGleanManager {
       ...mapSubscriptionCancellation(subscriptionCancellationData),
     };
   }
+
+  private get isEnabled() {
+    return this.paymentsGleanConfig.enabled && process.env['CI'] !== 'true';
+  }
 }