Skip to content

impr(input-indicator): add input indicator to more modals (@Leonabcd123)#7918

Open
Leonabcd123 wants to merge 1 commit intomonkeytypegame:masterfrom
Leonabcd123:fix/input-indicator
Open

impr(input-indicator): add input indicator to more modals (@Leonabcd123)#7918
Leonabcd123 wants to merge 1 commit intomonkeytypegame:masterfrom
Leonabcd123:fix/input-indicator

Conversation

@Leonabcd123
Copy link
Copy Markdown
Contributor

@Leonabcd123 Leonabcd123 commented May 6, 2026

Changed modals:

  • Custom test duration
  • Custom word amount
  • Quote submit
  • Save custom text

All of these have validation for some of their fields, but don't have the input validation indicator enabled.

@monkeytypegeorge monkeytypegeorge added the frontend User interface or web stuff label May 6, 2026
@Leonabcd123 Leonabcd123 changed the title fix(input-indicator): add input indicator to more modals (@Leonabcd123) impr(input-indicator): add input indicator to more modals (@Leonabcd123) May 6, 2026
@fehmer
Copy link
Copy Markdown
Member

fehmer commented May 6, 2026

I havent tested this yet, but maybe we could remove the showIndicatorproperty and check for props.field().options.validatorsto be present?

It is kind of odd to define validations on a field but don't want to show the indicator for it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend User interface or web stuff

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants