feat(sounds): add 14 mechanical sounds (@mshareef-git)#7764
feat(sounds): add 14 mechanical sounds (@mshareef-git)#7764mshareef-git wants to merge 79 commits intomonkeytypegame:masterfrom
Conversation
|
Any Updates? |
|
Hey, can you make sure all sounds are normalized to -10db? Also i would remove shadowgun, og oreo and cherrymx red. I also think with realistic sounds like mechanical switches, they would benefit greatly from less repetition by adding more sounds. (also sorry it took me this long) |
|
hey @Miodec sorry for the late reply i was a little busy, i have normalized all sounds to -10db, and removed those sound effects u mentioned. i am working on some other sound effects to but let me know if any changes are required. |
| <button data-config-value="14">fist fight</button> | ||
| <button data-config-value="15">rubber keys</button> | ||
| <button data-config-value="16">fart</button> | ||
| <button data-config-value="18">akko lavenders</button> |
There was a problem hiding this comment.
please change the ids to not have gaps
|
hi @mshareef-git , thank you for your contribution.
|
|
Hi @fehmer, thank you for the detailed feedback! I’ll be honest I’m still learning the ropes here, so I didn't quite catch everything you mentioned. I’m happy to apologize for the mess with the original wav files and the mp3s. I'll make sure to fix those and trim the folders down to 10 sounds each. Since you asked me to wait until your PR #7884 is merged: About how long do you think that might take? Also, should I wait until then to push the audio file fixes (WAV conversion and trimming), or should I do that part now? Thanks for your patience with me. |
|
Hi @mshareef-git , best would be for you to address the review comments and revert the changes in the sounds controller. I could either ping you when the PR got merged or add the changes needed for you. |
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
fehmer
left a comment
There was a problem hiding this comment.
Hi,
my PR got merged.
- please check the click ids have no gapps
- some sounds stll have more than 10 variants
- file structure changed to frontend/static/sounds/click{id}/{variantNumber}.wav please adjust
| "14": "fist fight", | ||
| "15": "rubber keys", | ||
| "16": "fart", | ||
| "17": "cherrymx red pbt", |
There was a problem hiding this comment.
this is different than settings.html, it should be the same
| @@ -144,6 +144,20 @@ export const PlaySoundOnClickSchema = z.enum([ | |||
| "14", | |||
| "15", | |||
| "16", | |||
| "17", | |||
There was a problem hiding this comment.
does't match up with the ids from settings.html
Bumps [nodemailer](https://github.com/nodemailer/nodemailer) from 7.0.11 to 8.0.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/nodemailer/nodemailer/releases">nodemailer's releases</a>.</em></p> <blockquote> <h2>v8.0.4</h2> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v8.0.3...v8.0.4">8.0.4</a> (2026-03-25)</h2> <h3>Bug Fixes</h3> <ul> <li>sanitize envelope size to prevent SMTP command injection (<a href="https://github.com/nodemailer/nodemailer/commit/2d7b9710e63555a1eb13d721296c51186d4b5651">2d7b971</a>)</li> </ul> <h2>v8.0.3</h2> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v8.0.2...v8.0.3">8.0.3</a> (2026-03-18)</h2> <h3>Bug Fixes</h3> <ul> <li>clean up addressparser and fix group name fallback producing undefined (<a href="https://github.com/nodemailer/nodemailer/commit/9d55877f8ed15a6aefd7ba76cbb6b6a6cdbcc4fd">9d55877</a>)</li> <li>fix cookie bugs, remove dead code, and improve hot-path efficiency (<a href="https://github.com/nodemailer/nodemailer/commit/e8c8b92f46f2a82d06d49cc9a6ffc26067f68524">e8c8b92</a>)</li> <li>refactor smtp-connection for clarity and add Node.js 6 syntax compat test (<a href="https://github.com/nodemailer/nodemailer/commit/c5b48ea61c28eabf347972f4198a12cdab226ff7">c5b48ea</a>)</li> <li>remove familySupportCache that broke DNS resolution tests (<a href="https://github.com/nodemailer/nodemailer/commit/c803d901f195a21edbb2c276b2e116564467aaaa">c803d90</a>)</li> </ul> <h2>v8.0.2</h2> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v8.0.1...v8.0.2">8.0.2</a> (2026-03-09)</h2> <h3>Bug Fixes</h3> <ul> <li>merge fragmented display names with unquoted commas in addressparser (<a href="https://github.com/nodemailer/nodemailer/commit/fe27f7fd57f7587d897274438da2f628ad0ad7d9">fe27f7f</a>)</li> </ul> <h2>v8.0.1</h2> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v8.0.0...v8.0.1">8.0.1</a> (2026-02-07)</h2> <h3>Bug Fixes</h3> <ul> <li>absorb TLS errors during socket teardown (<a href="https://github.com/nodemailer/nodemailer/commit/7f8dde41438c66b8311e888fa5f8c518fcaba6f1">7f8dde4</a>)</li> <li>absorb TLS errors during socket teardown (<a href="https://github.com/nodemailer/nodemailer/commit/381f628d55e62bb3131bd2a452fa1ce00bc48aea">381f628</a>)</li> <li>Add Gmail Workspace service configuration (<a href="https://redirect.github.com/nodemailer/nodemailer/issues/1787">#1787</a>) (<a href="https://github.com/nodemailer/nodemailer/commit/dc97ede417b3030b311771541b1f17f5ca76bcbf">dc97ede</a>)</li> </ul> <h2>v8.0.0</h2> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v7.0.13...v8.0.0">8.0.0</a> (2026-02-04)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>Error code 'NoAuth' renamed to 'ENOAUTH'</li> </ul> <h3>Bug Fixes</h3> <ul> <li>add connection fallback to alternative DNS addresses (<a href="https://github.com/nodemailer/nodemailer/commit/e726d6f44aa7ca14e943d4303243cb5494b09c75">e726d6f</a>)</li> <li>centralize and standardize error codes (<a href="https://github.com/nodemailer/nodemailer/commit/45062ce7a4705f3e63c5d9e606547f4d99fd29b5">45062ce</a>)</li> <li>harden DNS fallback against race conditions and cleanup issues (<a href="https://github.com/nodemailer/nodemailer/commit/4fa3c63a1f36aefdbaea7f57a133adc458413a47">4fa3c63</a>)</li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/nodemailer/nodemailer/blob/master/CHANGELOG.md">nodemailer's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v8.0.3...v8.0.4">8.0.4</a> (2026-03-25)</h2> <h3>Bug Fixes</h3> <ul> <li>sanitize envelope size to prevent SMTP command injection (<a href="https://github.com/nodemailer/nodemailer/commit/2d7b9710e63555a1eb13d721296c51186d4b5651">2d7b971</a>)</li> </ul> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v8.0.2...v8.0.3">8.0.3</a> (2026-03-18)</h2> <h3>Bug Fixes</h3> <ul> <li>clean up addressparser and fix group name fallback producing undefined (<a href="https://github.com/nodemailer/nodemailer/commit/9d55877f8ed15a6aefd7ba76cbb6b6a6cdbcc4fd">9d55877</a>)</li> <li>fix cookie bugs, remove dead code, and improve hot-path efficiency (<a href="https://github.com/nodemailer/nodemailer/commit/e8c8b92f46f2a82d06d49cc9a6ffc26067f68524">e8c8b92</a>)</li> <li>refactor smtp-connection for clarity and add Node.js 6 syntax compat test (<a href="https://github.com/nodemailer/nodemailer/commit/c5b48ea61c28eabf347972f4198a12cdab226ff7">c5b48ea</a>)</li> <li>remove familySupportCache that broke DNS resolution tests (<a href="https://github.com/nodemailer/nodemailer/commit/c803d901f195a21edbb2c276b2e116564467aaaa">c803d90</a>)</li> </ul> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v8.0.1...v8.0.2">8.0.2</a> (2026-03-09)</h2> <h3>Bug Fixes</h3> <ul> <li>merge fragmented display names with unquoted commas in addressparser (<a href="https://github.com/nodemailer/nodemailer/commit/fe27f7fd57f7587d897274438da2f628ad0ad7d9">fe27f7f</a>)</li> </ul> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v8.0.0...v8.0.1">8.0.1</a> (2026-02-07)</h2> <h3>Bug Fixes</h3> <ul> <li>absorb TLS errors during socket teardown (<a href="https://github.com/nodemailer/nodemailer/commit/7f8dde41438c66b8311e888fa5f8c518fcaba6f1">7f8dde4</a>)</li> <li>absorb TLS errors during socket teardown (<a href="https://github.com/nodemailer/nodemailer/commit/381f628d55e62bb3131bd2a452fa1ce00bc48aea">381f628</a>)</li> <li>Add Gmail Workspace service configuration (<a href="https://redirect.github.com/nodemailer/nodemailer/issues/1787">#1787</a>) (<a href="https://github.com/nodemailer/nodemailer/commit/dc97ede417b3030b311771541b1f17f5ca76bcbf">dc97ede</a>)</li> </ul> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v7.0.13...v8.0.0">8.0.0</a> (2026-02-04)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>Error code 'NoAuth' renamed to 'ENOAUTH'</li> </ul> <h3>Bug Fixes</h3> <ul> <li>add connection fallback to alternative DNS addresses (<a href="https://github.com/nodemailer/nodemailer/commit/e726d6f44aa7ca14e943d4303243cb5494b09c75">e726d6f</a>)</li> <li>centralize and standardize error codes (<a href="https://github.com/nodemailer/nodemailer/commit/45062ce7a4705f3e63c5d9e606547f4d99fd29b5">45062ce</a>)</li> <li>harden DNS fallback against race conditions and cleanup issues (<a href="https://github.com/nodemailer/nodemailer/commit/4fa3c63a1f36aefdbaea7f57a133adc458413a47">4fa3c63</a>)</li> <li>improve socket cleanup to prevent potential memory leaks (<a href="https://github.com/nodemailer/nodemailer/commit/6069fdcff68a3eef9a9bb16b2bf5ddb924c02091">6069fdc</a>)</li> </ul> <h2><a href="https://github.com/nodemailer/nodemailer/compare/v7.0.12...v7.0.13">7.0.13</a> (2026-01-27)</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/nodemailer/nodemailer/commit/2d319753c34d2f0ced24d8eb1d7d866d965f59f4"><code>2d31975</code></a> chore(master): release 8.0.4 (<a href="https://redirect.github.com/nodemailer/nodemailer/issues/1806">#1806</a>)</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/2d7b9710e63555a1eb13d721296c51186d4b5651"><code>2d7b971</code></a> fix: sanitize envelope size to prevent SMTP command injection</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/4e702e97650aaff442a7bc040957ba9c53c614b8"><code>4e702e9</code></a> chore(master): release 8.0.3 (<a href="https://redirect.github.com/nodemailer/nodemailer/issues/1804">#1804</a>)</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/c803d901f195a21edbb2c276b2e116564467aaaa"><code>c803d90</code></a> fix: remove familySupportCache that broke DNS resolution tests</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/e8c8b92f46f2a82d06d49cc9a6ffc26067f68524"><code>e8c8b92</code></a> fix: fix cookie bugs, remove dead code, and improve hot-path efficiency</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/0e78ee142b83cd967b5c451bb929f11dd4098f8e"><code>0e78ee1</code></a> chore: update dependencies</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/af73b4cd165d92271576e27b3678eb028bab5f44"><code>af73b4c</code></a> chore: upgrade GitHub Actions to latest versions</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/604b5702e463ed85828de57402b8332a371f838c"><code>604b570</code></a> chore: simplify remaining lib modules for clarity and consistency</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/4ced83d5ce5c61865783d8fb672f98447b52b739"><code>4ced83d</code></a> chore: simplify shared, errors, mailer, mime-node, and mime-funcs modules</li> <li><a href="https://github.com/nodemailer/nodemailer/commit/0cba16e16509d6d2af0899dbb2420e587172f233"><code>0cba16e</code></a> chore: simplify smtp-pool with const, Object.assign, and cleaner control flow</li> <li>Additional commits viewable in <a href="https://github.com/nodemailer/nodemailer/compare/v7.0.11...v8.0.4">compare view</a></li> </ul> </details> <br /> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…onkeytypegame#7781) * I think it's better to have the fallback as empty than showing the internal filed name as placeholder <img width="703" height="370" alt="Screenshot 2026-04-06 155427" src="https://github.com/user-attachments/assets/e289425d-7df6-4e10-bc0c-c160f6cbd9cd" /> fields with labels don't need a placeholder at all, and the ones that do we put them manually
[//]: # (dependabot-start)⚠️ **Dependabot is rebasing this PR**⚠️ Rebasing might not happen immediately, so don't worry if this takes some time. Note: if you make any changes to this PR yourself, they will take precedence over the rebase. --- [//]: # (dependabot-end) Bumps [vite](https://github.com/vitejs/vite/tree/HEAD/packages/vite) from 8.0.1 to 8.0.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/releases">vite's releases</a>.</em></p> <blockquote> <h2>v8.0.5</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v8.0.5/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v8.0.4</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v8.0.4/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>[email protected]</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/[email protected]/packages/create-vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v8.0.3</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v8.0.3/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>[email protected]</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/[email protected]/packages/create-vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> <h2>v8.0.2</h2> <p>Please refer to <a href="https://github.com/vitejs/vite/blob/v8.0.2/packages/vite/CHANGELOG.md">CHANGELOG.md</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/vitejs/vite/blob/main/packages/vite/CHANGELOG.md">vite's changelog</a>.</em></p> <blockquote> <h2><!-- raw HTML omitted --><a href="https://github.com/vitejs/vite/compare/v8.0.4...v8.0.5">8.0.5</a> (2026-04-06)<!-- raw HTML omitted --></h2> <h3>Bug Fixes</h3> <ul> <li>apply server.fs check to env transport (<a href="https://redirect.github.com/vitejs/vite/issues/22159">#22159</a>) (<a href="https://github.com/vitejs/vite/commit/f02d9fde0b195afe3ea2944414186962fbbe41e0">f02d9fd</a>)</li> <li>avoid path traversal with optimize deps sourcemap handler (<a href="https://redirect.github.com/vitejs/vite/issues/22161">#22161</a>) (<a href="https://github.com/vitejs/vite/commit/79f002f2286c03c88c7b74c511c7f9fc6dc46694">79f002f</a>)</li> <li>check <code>server.fs</code> after stripping query as well (<a href="https://redirect.github.com/vitejs/vite/issues/22160">#22160</a>) (<a href="https://github.com/vitejs/vite/commit/a9a3df299378d9cbc5f069e3536a369f8188c8ff">a9a3df2</a>)</li> <li>disallow referencing files outside the package from sourcemap (<a href="https://redirect.github.com/vitejs/vite/issues/22158">#22158</a>) (<a href="https://github.com/vitejs/vite/commit/f05f50173461789e0f1323fe06b51f18ca41c132">f05f501</a>)</li> </ul> <h2><!-- raw HTML omitted --><a href="https://github.com/vitejs/vite/compare/v8.0.3...v8.0.4">8.0.4</a> (2026-04-06)<!-- raw HTML omitted --></h2> <h3>Features</h3> <ul> <li>allow esbuild 0.28 as peer deps (<a href="https://redirect.github.com/vitejs/vite/issues/22155">#22155</a>) (<a href="https://github.com/vitejs/vite/commit/b0da97372f5dba73e78035d1cc7680466ff6cf7f">b0da973</a>)</li> <li><strong>hmr:</strong> truncate list of files on hmr update (<a href="https://redirect.github.com/vitejs/vite/issues/21535">#21535</a>) (<a href="https://github.com/vitejs/vite/commit/d00e806d7be15ebbfe7875e9244963d80ee8b142">d00e806</a>)</li> <li><strong>optimizer:</strong> log when dependency scanning or bundling takes over 1s (<a href="https://redirect.github.com/vitejs/vite/issues/21797">#21797</a>) (<a href="https://github.com/vitejs/vite/commit/f61a1ab33b05dc6f6a7eda6e8bc9c4c5b9aab133">f61a1ab</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li><code>hasBothRollupOptionsAndRolldownOptions</code> should return <code>false</code> for proxy case (<a href="https://redirect.github.com/vitejs/vite/issues/22043">#22043</a>) (<a href="https://github.com/vitejs/vite/commit/99897d27b44dd73307fa03e2f11f0baa1a1dc939">99897d2</a>)</li> <li>add types for <code>vite/modulepreload-polyfill</code> (<a href="https://redirect.github.com/vitejs/vite/issues/22126">#22126</a>) (<a href="https://github.com/vitejs/vite/commit/17330d2b9e132460f194d6d4b547cfee7e25c788">17330d2</a>)</li> <li><strong>deps:</strong> update all non-major dependencies (<a href="https://redirect.github.com/vitejs/vite/issues/22073">#22073</a>) (<a href="https://github.com/vitejs/vite/commit/6daa10ff1e8d15a90f49d8dd909ff208da85d6d8">6daa10f</a>)</li> <li><strong>deps:</strong> update all non-major dependencies (<a href="https://redirect.github.com/vitejs/vite/issues/22143">#22143</a>) (<a href="https://github.com/vitejs/vite/commit/22b016612703320db45c64a2fe44472051ef5ec5">22b0166</a>)</li> <li><strong>resolve:</strong> resolve tsconfig paths starting with <code>#</code> (<a href="https://redirect.github.com/vitejs/vite/issues/22038">#22038</a>) (<a href="https://github.com/vitejs/vite/commit/3460fc55aa89aef4103d2c05ac2e446032511a6d">3460fc5</a>)</li> <li><strong>ssr:</strong> use browser platform for webworker SSR builds (fix <a href="https://redirect.github.com/vitejs/vite/issues/21969">#21969</a>) (<a href="https://redirect.github.com/vitejs/vite/issues/21963">#21963</a>) (<a href="https://github.com/vitejs/vite/commit/364c2273a121dad4d93ec3b9ec87ffbe0d6e860b">364c227</a>)</li> </ul> <h3>Documentation</h3> <ul> <li>add <code>environment.fetchModule</code> documentation (<a href="https://redirect.github.com/vitejs/vite/issues/22035">#22035</a>) (<a href="https://github.com/vitejs/vite/commit/54229e78631ebf10d1db767b51ea85f3cf06718a">54229e7</a>)</li> </ul> <h3>Miscellaneous Chores</h3> <ul> <li><strong>deps:</strong> update rolldown-related dependencies (<a href="https://redirect.github.com/vitejs/vite/issues/21989">#21989</a>) (<a href="https://github.com/vitejs/vite/commit/0ded6274579e8bda6b22a7ba93b15d15b4c28b78">0ded627</a>)</li> </ul> <h3>Code Refactoring</h3> <ul> <li>upgrade to typescript 6 (<a href="https://redirect.github.com/vitejs/vite/issues/22110">#22110</a>) (<a href="https://github.com/vitejs/vite/commit/cc41398c2cf0bb5061cf0ca5dc3b408ae7e41191">cc41398</a>)</li> </ul> <h2><!-- raw HTML omitted --><a href="https://github.com/vitejs/vite/compare/v8.0.2...v8.0.3">8.0.3</a> (2026-03-26)<!-- raw HTML omitted --></h2> <h3>Features</h3> <ul> <li>update rolldown to 1.0.0-rc.12 (<a href="https://redirect.github.com/vitejs/vite/issues/22024">#22024</a>) (<a href="https://github.com/vitejs/vite/commit/84164ef47b24b1de114f1c29446a9e650825d4ea">84164ef</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li><strong>html:</strong> cache unfiltered CSS list to prevent missing styles across entries (<a href="https://redirect.github.com/vitejs/vite/issues/22017">#22017</a>) (<a href="https://github.com/vitejs/vite/commit/5464190a3ee8f23db20004e7818186fbcc32b0e5">5464190</a>)</li> <li><strong>module-runner:</strong> handle non-ascii characters in base64 sourcemaps (<a href="https://redirect.github.com/vitejs/vite/issues/21985">#21985</a>) (<a href="https://github.com/vitejs/vite/commit/77c95bff834c43f8be9fe513c10b5393805a7487">77c95bf</a>)</li> <li><strong>module-runner:</strong> skip re-import if the runner is closed (<a href="https://redirect.github.com/vitejs/vite/issues/22020">#22020</a>) (<a href="https://github.com/vitejs/vite/commit/ee2c2cd2c2ce3f53088bd2313fa23e9d52a49b4f">ee2c2cd</a>)</li> <li><strong>optimizer:</strong> scan is not resolving sub path import if used in a glob import (<a href="https://redirect.github.com/vitejs/vite/issues/22018">#22018</a>) (<a href="https://github.com/vitejs/vite/commit/ddfe20d19e95a323fa3c8d2c19a02c4e02f93824">ddfe20d</a>)</li> <li><strong>ssr:</strong> ssrTransform incorrectly rewrites <code>meta</code> identifier inside <code>import.meta</code> when a binding named <code>meta</code> exists (<a href="https://redirect.github.com/vitejs/vite/issues/22019">#22019</a>) (<a href="https://github.com/vitejs/vite/commit/cff5f0cca5f08c2ce50f233441485e10b6e115e9">cff5f0c</a>)</li> </ul> <h3>Miscellaneous Chores</h3> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitejs/vite/commit/1a12d4ca4c62eedaeaf734d722b27ab17b5b1dd0"><code>1a12d4c</code></a> release: v8.0.5</li> <li><a href="https://github.com/vitejs/vite/commit/79f002f2286c03c88c7b74c511c7f9fc6dc46694"><code>79f002f</code></a> fix: avoid path traversal with optimize deps sourcemap handler (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/22161">#22161</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/a9a3df299378d9cbc5f069e3536a369f8188c8ff"><code>a9a3df2</code></a> fix: check <code>server.fs</code> after stripping query as well (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/22160">#22160</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/f02d9fde0b195afe3ea2944414186962fbbe41e0"><code>f02d9fd</code></a> fix: apply server.fs check to env transport (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/22159">#22159</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/f05f50173461789e0f1323fe06b51f18ca41c132"><code>f05f501</code></a> fix: disallow referencing files outside the package from sourcemap (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/22158">#22158</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/7339bdc915c297e16e6530f6ebcbb2509cb57f24"><code>7339bdc</code></a> release: v8.0.4</li> <li><a href="https://github.com/vitejs/vite/commit/54229e78631ebf10d1db767b51ea85f3cf06718a"><code>54229e7</code></a> docs: add <code>environment.fetchModule</code> documentation (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/22035">#22035</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/b0da97372f5dba73e78035d1cc7680466ff6cf7f"><code>b0da973</code></a> feat: allow esbuild 0.28 as peer deps (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/22155">#22155</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/22b016612703320db45c64a2fe44472051ef5ec5"><code>22b0166</code></a> fix(deps): update all non-major dependencies (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/22143">#22143</a>)</li> <li><a href="https://github.com/vitejs/vite/commit/17330d2b9e132460f194d6d4b547cfee7e25c788"><code>17330d2</code></a> fix: add types for <code>vite/modulepreload-polyfill</code> (<a href="https://github.com/vitejs/vite/tree/HEAD/packages/vite/issues/22126">#22126</a>)</li> <li>Additional commits viewable in <a href="https://github.com/vitejs/vite/commits/v8.0.5/packages/vite">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/monkeytypegame/monkeytype/network/alerts). </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…game#7814) ### Description In the theme section in setting, the selected theme is bigger and outlined, that caused it to appear of top of `themeBubbles`/`themeBubble` of the theme that is hovered on it's left. What I did is instead of only making the button bigger when hovered, I also added `z-index` so that it appears on top of the already selected theme. closes monkeytypegame#7797
Bumps [uuid](https://github.com/uuidjs/uuid) from 10.0.0 to 14.0.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/uuidjs/uuid/releases">uuid's releases</a>.</em></p> <blockquote> <h2>v14.0.0</h2> <h2><a href="https://github.com/uuidjs/uuid/compare/v13.0.0...v14.0.0">14.0.0</a> (2026-04-19)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>expect <code>crypto</code> to be global everywhere (requires node@20+) (<a href="https://redirect.github.com/uuidjs/uuid/issues/935">#935</a>)</li> <li>drop node@18 support (<a href="https://redirect.github.com/uuidjs/uuid/issues/934">#934</a>)</li> </ul> <h3>Features</h3> <ul> <li>drop node@18 support (<a href="https://redirect.github.com/uuidjs/uuid/issues/934">#934</a>) (<a href="https://github.com/uuidjs/uuid/commit/dc4ddb87272ed2843faccd130bcc41d492688bd3">dc4ddb8</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li>expect <code>crypto</code> to be global everywhere (requires node@20+) (<a href="https://redirect.github.com/uuidjs/uuid/issues/935">#935</a>) (<a href="https://github.com/uuidjs/uuid/commit/f2c235f93059325fa43e1106e624b5291bb523c4">f2c235f</a>)</li> <li>Use GITHUB_TOKEN for release-please and enable npm provenance (<a href="https://redirect.github.com/uuidjs/uuid/issues/925">#925</a>) (<a href="https://github.com/uuidjs/uuid/commit/ffa31383e8e4e1f0b4e22e504561272041b8738c">ffa3138</a>)</li> </ul> <h2>v13.0.1</h2> <h2><a href="https://github.com/uuidjs/uuid/compare/v13.0.0...v13.0.1">13.0.1</a> (2026-04-27)</h2> <h3>Bug Fixes</h3> <ul> <li>backport fix for GHSA-w5hq-g745-h8pq (<a href="https://github.com/uuidjs/uuid/commit/9d27ddf7046ce496ef39569ff84d948eeff9cb2a">9d27ddf</a>)</li> </ul> <h2>v13.0.0</h2> <h2><a href="https://github.com/uuidjs/uuid/compare/v12.0.0...v13.0.0">13.0.0</a> (2025-09-08)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>make browser exports the default (<a href="https://redirect.github.com/uuidjs/uuid/issues/901">#901</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li>make browser exports the default (<a href="https://redirect.github.com/uuidjs/uuid/issues/901">#901</a>) (<a href="https://github.com/uuidjs/uuid/commit/bce9d72a3ae5b9a3dcd8eb21ef6d1820288a427a">bce9d72</a>)</li> </ul> <h2>v12.0.1</h2> <h2><a href="https://github.com/uuidjs/uuid/compare/v12.0.0...v12.0.1">12.0.1</a> (2026-04-29)</h2> <h3>Bug Fixes</h3> <ul> <li>backport fix for GHSA-w5hq-g745-h8pq (<a href="https://github.com/uuidjs/uuid/commit/3d61d6ac1f782cf6b1dd8661c60f11722cd49a0d">3d61d6a</a>)</li> </ul> <h2>v12.0.0</h2> <h2><a href="https://github.com/uuidjs/uuid/compare/v11.1.0...v12.0.0">12.0.0</a> (2025-09-05)</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/uuidjs/uuid/blob/main/CHANGELOG.md">uuid's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/uuidjs/uuid/compare/v13.0.0...v14.0.0">14.0.0</a> (2026-04-19)</h2> <h3>Security</h3> <ul> <li>Fixes <a href="https://github.com/uuidjs/uuid/security/advisories/GHSA-w5hq-g745-h8pq">GHSA-w5hq-g745-h8pq</a>: <code>v3()</code>, <code>v5()</code>, and <code>v6()</code> did not validate that writes would remain within the bounds of a caller-supplied buffer, allowing out-of-bounds writes when an invalid <code>offset</code> was provided. A <code>RangeError</code> is now thrown if <code>offset < 0</code> or <code>offset + 16 > buf.length</code>.</li> </ul> <h3>⚠ BREAKING CHANGES</h3> <ul> <li><code>crypto</code> is now expected to be globally defined (requires node@20+) (<a href="https://redirect.github.com/uuidjs/uuid/issues/935">#935</a>)</li> <li>drop node@18 support (<a href="https://redirect.github.com/uuidjs/uuid/issues/934">#934</a>)</li> <li>upgrade minimum supported TypeScript version to 5.4.3, in keeping with the project's policy of supporting TypeScript versions released within the last two years</li> </ul> <h2><a href="https://github.com/uuidjs/uuid/compare/v12.0.0...v13.0.0">13.0.0</a> (2025-09-08)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>make browser exports the default (<a href="https://redirect.github.com/uuidjs/uuid/issues/901">#901</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li>make browser exports the default (<a href="https://redirect.github.com/uuidjs/uuid/issues/901">#901</a>) (<a href="https://github.com/uuidjs/uuid/commit/bce9d72a3ae5b9a3dcd8eb21ef6d1820288a427a">bce9d72</a>)</li> </ul> <h2><a href="https://github.com/uuidjs/uuid/compare/v11.1.0...v12.0.0">12.0.0</a> (2025-09-05)</h2> <h3>⚠ BREAKING CHANGES</h3> <ul> <li>update to [email protected] (<a href="https://redirect.github.com/uuidjs/uuid/issues/887">#887</a>)</li> <li>remove CommonJS support (<a href="https://redirect.github.com/uuidjs/uuid/issues/886">#886</a>)</li> <li>drop node@16 support (<a href="https://redirect.github.com/uuidjs/uuid/issues/883">#883</a>)</li> </ul> <h3>Features</h3> <ul> <li>add node@24 to ci matrix (<a href="https://redirect.github.com/uuidjs/uuid/issues/879">#879</a>) (<a href="https://github.com/uuidjs/uuid/commit/42b6178aa21a593257f0a72abacd220f0b7b8a92">42b6178</a>)</li> <li>drop node@16 support (<a href="https://redirect.github.com/uuidjs/uuid/issues/883">#883</a>) (<a href="https://github.com/uuidjs/uuid/commit/0f38cf10366ab074f9328ae2021eea04d5f2e530">0f38cf1</a>)</li> <li>remove CommonJS support (<a href="https://redirect.github.com/uuidjs/uuid/issues/886">#886</a>) (<a href="https://github.com/uuidjs/uuid/commit/ae786e27265f50bcf7cead196c29f1869297c42f">ae786e2</a>)</li> <li>update to [email protected] (<a href="https://redirect.github.com/uuidjs/uuid/issues/887">#887</a>) (<a href="https://github.com/uuidjs/uuid/commit/c7ee40598ed78584d81ab78dffded9fe5ff20b01">c7ee405</a>)</li> </ul> <h3>Bug Fixes</h3> <ul> <li>improve v4() performance (<a href="https://redirect.github.com/uuidjs/uuid/issues/894">#894</a>) (<a href="https://github.com/uuidjs/uuid/commit/5fd974c12718c8848035650b69b8948f12ace197">5fd974c</a>)</li> <li>restore node: prefix (<a href="https://redirect.github.com/uuidjs/uuid/issues/889">#889</a>) (<a href="https://github.com/uuidjs/uuid/commit/e1f42a354593093ba0479f0b4047dae82d28c507">e1f42a3</a>)</li> </ul> <h2><a href="https://github.com/uuidjs/uuid/compare/v11.0.5...v11.1.0">11.1.0</a> (2025-02-19)</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/uuidjs/uuid/commit/7c1ea087a8149b57380fc8bb7f68c3a215cb6e4b"><code>7c1ea08</code></a> chore(main): release 14.0.0 (<a href="https://redirect.github.com/uuidjs/uuid/issues/926">#926</a>)</li> <li><a href="https://github.com/uuidjs/uuid/commit/3d2c5b0342f0fcb52a5ac681c3d47c13e7444b34"><code>3d2c5b0</code></a> Merge commit from fork</li> <li><a href="https://github.com/uuidjs/uuid/commit/f2c235f93059325fa43e1106e624b5291bb523c4"><code>f2c235f</code></a> fix!: expect <code>crypto</code> to be global everywhere (requires node@20+) (<a href="https://redirect.github.com/uuidjs/uuid/issues/935">#935</a>)</li> <li><a href="https://github.com/uuidjs/uuid/commit/529ef0899f5dd503d2ee90d690585d63d78bc212"><code>529ef08</code></a> chore: upgrade TypeScript and fixup types (<a href="https://redirect.github.com/uuidjs/uuid/issues/927">#927</a>)</li> <li><a href="https://github.com/uuidjs/uuid/commit/086fd7976f11433edf9ac80be876b3ad243fe087"><code>086fd79</code></a> chore: update dependencies (<a href="https://redirect.github.com/uuidjs/uuid/issues/933">#933</a>)</li> <li><a href="https://github.com/uuidjs/uuid/commit/dc4ddb87272ed2843faccd130bcc41d492688bd3"><code>dc4ddb8</code></a> feat!: drop node@18 support (<a href="https://redirect.github.com/uuidjs/uuid/issues/934">#934</a>)</li> <li><a href="https://github.com/uuidjs/uuid/commit/0f1f9c9c9cedbae5a1d363d5406c5dfbabe81404"><code>0f1f9c9</code></a> chore: switch to Biome for parsing and linting (<a href="https://redirect.github.com/uuidjs/uuid/issues/932">#932</a>)</li> <li><a href="https://github.com/uuidjs/uuid/commit/e2879e64bf125add903c1eff6e0860542c605013"><code>e2879e6</code></a> chore: use maintained version of npm-run-all (<a href="https://redirect.github.com/uuidjs/uuid/issues/930">#930</a>)</li> <li><a href="https://github.com/uuidjs/uuid/commit/ffa31383e8e4e1f0b4e22e504561272041b8738c"><code>ffa3138</code></a> fix: Use GITHUB_TOKEN for release-please and enable npm provenance (<a href="https://redirect.github.com/uuidjs/uuid/issues/925">#925</a>)</li> <li><a href="https://github.com/uuidjs/uuid/commit/0423d49df2dc8efc300c804731d25f4d7e0fccc4"><code>0423d49</code></a> docs: remove obsolete v1 option notes (<a href="https://redirect.github.com/uuidjs/uuid/issues/915">#915</a>)</li> <li>Additional commits viewable in <a href="https://github.com/uuidjs/uuid/compare/v10.0.0...v14.0.0">compare view</a></li> </ul> </details> <details> <summary>Maintainer changes</summary> <p>This version was pushed to npm by <a href="https://www.npmjs.com/~GitHub%20Actions">GitHub Actions</a>, a new releaser for uuid since your current version.</p> </details> <details> <summary>Install script changes</summary> <p>This version adds <code>prepare</code> script that runs during installation. Review the package contents before updating.</p> </details> <br /> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
### Description <!-- Please describe the change(s) made in your PR: - explain the problem being solved - for bug fixes without an open issue, include steps to reproduce the issue - summarize the approach taken Use your own words. Do not rely on AI-generated descriptions. They do not demonstrate your understanding of the problem or the solution. Writing the description yourself helps you verify the scope of your work and helps us better understand your intent, reasoning and level of insight. --> Adds Bemba language support to Monkeytype with three word lists: - `bemba` - `bemba_1k` - `bemba_10k` [Bemba](https://en.wikipedia.org/wiki/Bemba_language) is a Bantu language and is the most commonly spoken language in Zambia, with roughly 5-6 million speakers. I have had this language support working on a personal Monkeytype fork at https://typing.martinnn.com, and I wanted to contribute the language data upstream so it can be used by the wider Monkeytype community. Most of this data comes from work I did for my undergraduate thesis, where I built a morphological analyser for Bemba: https://project-archive.inf.ed.ac.uk/ug4/20244657/ug4_proj.pdf The language files use the BCP 47 tag `bem`, and include the metadata requested in the language contribution guide: - `rightToLeft: false` - `ligatures: false` - `orderedByFrequency: false` I also registered the new language variants in the schema and added them to a single Bemba language group. Validation run locally: ```bash pnpm run check-assets-languages ``` Result: Languages are all valid One note: the older checklist item mentions adding languages to `_list` and `_groups`. In the current codebase, those files have been replaced by `packages/schemas/src/ languages.ts` and `frontend/src/ts/constants/languages.ts`. This PR follows the current structure and passes `pnpm run check-assets-languages`. ### Checks - [ ] Adding quotes? - Make sure to follow the [quotes documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/QUOTES.md) - [ ] Make sure to include translations for the quotes in the description (or another comment) so we can verify their content. - [x] Adding a language? - Make sure to follow the [languages documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LANGUAGES.md) - [x] Add language to `packages/schemas/src/languages.ts` - [x] Add language to exactly one group in `frontend/src/ts/constants/languages.ts` - [x] Add language json file to `frontend/static/languages` - [ ] Adding a theme? - Make sure to follow the [themes documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/THEMES.md) - [ ] Add theme to `packages/schemas/src/themes.ts` - [ ] Add theme to `frontend/src/ts/constants/themes.ts` - [ ] (optional) Add theme css file to `frontend/static/themes` - [ ] Add some screenshots of the theme, especially with different test settings (colorful, flip colors) to your pull request - [ ] Adding a layout? - [ ] Make sure to follow the [layouts documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/LAYOUTS.md) - [ ] Add layout to `packages/schemas/src/layouts.ts` - [ ] Add layout json file to `frontend/static/layouts` - [ ] Adding a font? - Make sure to follow the [fonts documentation](https://github.com/monkeytypegame/monkeytype/blob/master/docs/FONTS.md) - [ ] Add font file to `frontend/static/webfonts` - [ ] Add font to `packages/schemas/src/fonts.ts` - [ ] Add font to `frontend/src/ts/constants/fonts.ts` - [ ] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. <!-- label(optional scope): pull request title (@your_github_username) --> <!-- I know I know they seem boring but please do them, they help us and you will find out it also helps you. --> Closes: n/a <!-- The issue(s) your PR resolves if any (delete if that is not the case) --> <!-- Please reference any issues and/or PRs related to your pull request --> <!-- Pro tip: you can mention an issue, PR, or discussion on GitHub by referencing its hash number, e.g.: [monkeytypegame#1234](monkeytypegame#1234) --> <!-- Pro tip: you can press . (dot or period) in the code tab of any GitHub repo to get access to GitHub's VS Code web editor. Enjoy! :) --> Co-authored-by: Jack <[email protected]>
…pegame#7820) ### Description Added an Oxford comma to the final line in the "Support" section of `README.md` to improve readability and grammatical consistency. ### Checks - [ ] Adding quotes? - [ ] Adding a language? - [ ] Adding a theme? - [ ] Adding a layout? - [ ] Adding a font? - [x] Check if any open issues are related to this PR; if so, be sure to tag them below. - [x] Make sure the PR title follows the Conventional Commits standard. (https://www.conventionalcommits.org for more info) - [x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title. Closes #
Co-authored-by: Christian Fehmer <[email protected]>
…fehmer, @Miodec) (monkeytypegame#7854) Migrates - account page - results - filter presets - tags --------- Co-authored-by: Miodec <[email protected]>
…keytypegame#7876) Fixes monkeytypegame#7875 Slow network connections caused the theme css to be applied on the #customTheme stylesheet link element after clearing the theme preview with `href=""`. Empty href is invalid, so best to remove the whole element if we don't need it: >The address of the link(s) is given by the href attribute. If the [href](https://html.spec.whatwg.org/multipage/semantics.html#attr-link-href) attribute is present, then its value must be a [valid non-empty URL potentially surrounded by spaces](https://html.spec.whatwg.org/multipage/urls-and-fetching.html#valid-non-empty-url-potentially-surrounded-by-spaces). https://html.spec.whatwg.org/multipage/semantics.html#attr-link-href While chrome is applying the last css file firefox removes it correctly but keeps the loaderBar active because of the missing onLoad callback
… trim variants to 10 max
…ture, align metadata IDs)
6d2b540 to
cd67f28
Compare
|
Continuous integration check(s) failed. Please review the failing check's logs and make the necessary changes. |
|
Hey @fehmer, just pushed the updates based on your review. I've closed the ID gaps, capped all variants at 10, and fixed the file naming structure. I also made sure the metadata IDs match up and took care of the merge conflicts. Let me know if any changes are required |
I really loved using sound effects in Monkeytype cause I don't have a mechanical keyboard, but there were limited options for sounds (just about 15 or so). That's why I added 14 new mechanical keyboard soundpacks. I previously contributed similar one called Wayvibes, so I wanted to bring that variety here.
below is the summary:
Added 14 new soundpacks (IDs click17 through click30) to frontend/static/sound/.
Included Sounds: Akko Lavenders, CherryMX (Black, Blue, Brown, Red in ABS/PBT), EG Oreo, Kailh Box White, Razer Green, Shadowgun, Tealios v2, and Trust GXT 865.
Standardized naming: Followed the existing clickXX_N.wav/mp3 format for all audio files to ensure consistency with the current codebase.
Code Updates:
Updated packages/schemas/src/configs.ts to whitelist new sound IDs.
Mapped new audio assets in frontend/src/ts/controllers/sound-controller.ts.
Added UI buttons in frontend/src/html/pages/settings.html and CLI aliases in frontend/src/ts/commandline/commandline-metadata.ts.
Checks
[ ] Adding quotes?
[ ] Adding a language?
[ ] Adding a theme?
[ ] Adding a layout?
[ ] Adding a font?
[x] Check if any open issues are related to this PR; if so, be sure to tag them below.
[x] Make sure the PR title follows the Conventional Commits standard.
[x] Make sure to include your GitHub username prefixed with @ inside parentheses at the end of the PR title.