Skip to content

DRIVERS-3207: Custom AWS credential providers execute earlier#1838

Merged
dariakp merged 15 commits intomasterfrom
DRIVERS-3207
Sep 18, 2025
Merged

DRIVERS-3207: Custom AWS credential providers execute earlier#1838
dariakp merged 15 commits intomasterfrom
DRIVERS-3207

Conversation

@durran
Copy link
Copy Markdown
Contributor

@durran durran commented Sep 9, 2025

Updates the AWS auth spec to require drivers that implement custom AWS credential providers to use the custom provider before any other method.

Updates test wording to include the extra scenario for testing a custom provider when explicit credentials are also provided.

Node implementation: mongodb/node-mongodb-native#4656

Please complete the following before merging:

  • Update changelog.
  • Test changes in at least one language driver.
  • Test these changes against all server versions and topologies (including standalone, replica set, and sharded
    clusters).

@durran durran force-pushed the DRIVERS-3207 branch 2 times, most recently from 174d5cb to b2ae9b3 Compare September 9, 2025 18:03
@durran durran marked this pull request as ready for review September 10, 2025 12:47
@durran durran requested a review from a team as a code owner September 10, 2025 12:47
@durran durran requested review from JamesKovacs and removed request for a team September 10, 2025 12:47
Comment thread source/auth/tests/mongodb-aws.md
Comment thread source/auth/auth.md
Comment thread source/auth/auth.md Outdated
Comment thread source/auth/auth.md
Comment thread source/auth/auth.md Outdated
Comment thread source/auth/auth.md
@dariakp dariakp self-assigned this Sep 10, 2025
@durran
Copy link
Copy Markdown
Contributor Author

durran commented Sep 11, 2025

#1838 (comment)

I have added a prose test for FLE in case 26. Case 15 I don't believe is relevant as it pertains to automatic credential fetching, which means nothing is provided. Even with the changes in this PR the order on automatic credential fetching is the same.

@durran durran requested a review from a team as a code owner September 11, 2025 13:29
@durran durran requested review from katcharov and removed request for a team September 11, 2025 13:29
@durran
Copy link
Copy Markdown
Contributor Author

durran commented Sep 11, 2025

#1838 (comment)

Added link.

@durran durran changed the title DRIVERS-3207: Custom AWS credential providers execute first DRIVERS-3207: Custom AWS credential providers execute earlier Sep 12, 2025
Comment thread source/auth/auth.md Outdated
Comment thread source/auth/auth.md Outdated
@dariakp dariakp requested review from atesteve and removed request for JamesKovacs September 15, 2025 23:06
@durran durran requested a review from dariakp September 16, 2025 10:45
@dariakp dariakp removed the request for review from atesteve September 16, 2025 18:45
Comment thread source/auth/auth.md Outdated
@katcharov katcharov requested a review from kevinAlbs September 16, 2025 19:46
@durran durran requested a review from katcharov September 17, 2025 10:34
Comment thread source/auth/tests/mongodb-aws.md Outdated
Comment thread source/auth/tests/mongodb-aws.md
@durran durran requested a review from kevinAlbs September 17, 2025 19:10
@dariakp dariakp requested review from baileympearson and removed request for baileympearson September 18, 2025 20:29
@dariakp dariakp dismissed baileympearson’s stale review September 18, 2025 20:30

declined re-review

@dariakp dariakp merged commit 4a46628 into master Sep 18, 2025
6 checks passed
@dariakp dariakp deleted the DRIVERS-3207 branch September 18, 2025 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants