test(NODE-7561): Skip QE "prefixPreview" and "suffixPreview" tests on server 9.0.0+#4934
Open
PavelSafronov wants to merge 8 commits intomainfrom
Open
test(NODE-7561): Skip QE "prefixPreview" and "suffixPreview" tests on server 9.0.0+#4934PavelSafronov wants to merge 8 commits intomainfrom
PavelSafronov wants to merge 8 commits intomainfrom
Conversation
… server 9.0.0+ Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CSFLE Queryable Encryption (QE) test coverage to avoid running deprecated prefixPreview / suffixPreview scenarios against MongoDB server versions where they’re no longer supported (9.0.0+), keeping CI green while the server/spec behavior diverges.
Changes:
- Add
maxServerVersion: 8.99.99run-on requirements to QE unified spec tests that rely onprefixPreview/suffixPreview. - Fix mislabeled
substringPreviewtest description in unified spec files. - Gate/skip integration test logic and spec-suite execution paths that would fail on MongoDB 9.0.0+.
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/spec/client-side-encryption/tests/unified/QE-Text-suffixPreview.yml | Restricts suffixPreview unified test to MongoDB < 9.0.0 |
| test/spec/client-side-encryption/tests/unified/QE-Text-suffixPreview.json | Same restriction in JSON form |
| test/spec/client-side-encryption/tests/unified/QE-Text-prefixPreview.yml | Restricts prefixPreview unified test to MongoDB < 9.0.0 |
| test/spec/client-side-encryption/tests/unified/QE-Text-prefixPreview.json | Same restriction in JSON form |
| test/spec/client-side-encryption/tests/unified/QE-Text-compactStructuredEncryptionData.yml | Restricts structured encryption test dependent on removed preview query types |
| test/spec/client-side-encryption/tests/unified/QE-Text-compactStructuredEncryptionData.json | Same restriction in JSON form |
| test/spec/client-side-encryption/tests/unified/QE-Text-cleanupStructuredEncryptionData.yml | Restricts cleanup structured encryption test dependent on removed preview query types |
| test/spec/client-side-encryption/tests/unified/QE-Text-cleanupStructuredEncryptionData.json | Same restriction in JSON form |
| test/spec/client-side-encryption/tests/unified/QE-Text-substringPreview.yml | Corrects test description label to substringPreview |
| test/spec/client-side-encryption/tests/unified/QE-Text-substringPreview.json | Same description correction in JSON form |
| test/integration/client-side-encryption/client_side_encryption.prose.27.text_queries.test.ts | Skips prefix/suffix setup and cases on MongoDB 9.0.0+ |
| test/integration/change-streams/change_streams.spec.test.ts | Attempts to version-gate unified spec suite for MongoDB 9.0.0+ |
Comment on lines
+8
to
+10
| it('should run, unless it should not', { requires: { mongodb: '<9.0' } }, function () { | ||
| runUnifiedSuite(loadSpecTests(path.join('change-streams', 'unified'))); | ||
| }); |
Comment on lines
+45
to
+46
| const isServer9OrAbove = this.configuration.version >= '9.0.0'; | ||
| const shouldRunPrefixSuffixTests = !isServer9OrAbove; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Notes for Reviewers
What is the motivation for this change?
Release Highlight
Release notes highlight
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript