Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Indexes integration test to assert only the stable/known fields from listIndexes() output, so the test remains compatible with newer server versions that include additional fields (e.g., collation).
Changes:
- Replace strict deep-equality assertion on
listIndexes()results with subset-based assertions. - Keep validating the presence of the hidden index while ignoring extra server-returned fields.
dariakp
approved these changes
Apr 17, 2026
dariakp
added
the
Primary Review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary of Changes
Only test known fields in the
listIndexesresponse. Latest server returns more fields (collation is included).Notes for Reviewers
What is the motivation for this change?
Failing test on latest server.
Double check the following
npm run check:lint)type(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript