Skip to content

test(NODE-7513): relax regression test for emptyGetMore #4916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tadjik1 merged 3 commits into from
Apr 14, 2026
+8 −9
Merged

test(NODE-7513): relax regression test for emptyGetMore #4916

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cfa3e10
test(NODE-7513): relax regression test for emptyGetMore
tadjik1 Apr 10, 2026
7fff5df
update the comment
tadjik1 Apr 10, 2026
5e55f92
modify test title, make it clear what is tested and how
tadjik1 Apr 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions test/integration/crud/find.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ import * as sinon from 'sinon';

import {
Code,
CursorResponse,
Long,
type MongoClient,
MongoServerError,
Expand Down Expand Up @@ -1075,29 +1074,29 @@ describe('Find', function () {
});

it(
'regression test (NODE-6878): CursorResponse.emptyGetMore contains all CursorResponse fields',
'regression test (NODE-6878): cursor can be rewound after limit-based exhaustion',
{ requires: { topology: 'sharded' } },
async function () {
const collection = client.db('rewind-regression').collection('bar');

await collection.deleteMany({});
await collection.insertMany(Array.from({ length: 4 }, (_, i) => ({ x: i })));

const getMoreSpy = sinon.spy(CursorResponse, 'emptyGetMore', ['get']);

const cursor = collection.find({}, { batchSize: 1, limit: 3 });
// emptyGetMore is used internally after limit + 1 documents have been iterated
// Iterate limit + 1 times to exercise the post-limit cursor path before rewind.
await cursor.next();
await cursor.next();
await cursor.next();
await cursor.next();

// assert that `emptyGetMore` is called. if it is not, this test
// always passes, even without the fix in NODE-6878.
expect(getMoreSpy.get).to.have.been.called;
Comment thread
dariakp marked this conversation as resolved.
// On servers < 9.0, mongos returns a non-zero cursorId even after the limit
// is satisfied, so the driver uses CursorResponse.emptyGetMore to avoid a
// wasted getMore. On 9.0+, mongos returns cursorId: 0 when the limit is
// reached. In both cases, rewinding and re-iterating the cursor must work.

// rewind + toArray must not throw. Before the NODE-6878 fix,
// this would fail with a TypeError from emptyGetMore lacking CursorResponse fields.
cursor.rewind();

await cursor.toArray();
}
);
Expand Down
Loading