Skip to content

test(NODE-7470): test that backpressure retries are non-blocking #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PavelSafronov merged 4 commits into from
Mar 20, 2026
+216 −10
Merged

test(NODE-7470): test that backpressure retries are non-blocking #4891

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1b14e86
test: backpressure retries are non-blocking
dariakp Mar 13, 2026
e798fd8
Merge branch 'main' into NODE-7470/test-backpressure-retries-are-nonb…
tadjik1 Mar 17, 2026
6a0af2b
unpin the session when a SystemOverloadedError occurs
tadjik1 Mar 17, 2026
a6e7f88
check the aspect Aspect.CURSOR_CREATING to prevent breaking cursor pi…
tadjik1 Mar 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions src/operations/execute_operation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,6 +349,15 @@ async function executeOperationWithRetries<
session.unpin({ force: true, forceClear: true });
}

if (
operationError.hasErrorLabel(MongoErrorLabel.SystemOverloadedError) &&
session != null &&
session.isPinned &&
!session.inTransaction()
) {
session.unpin({ force: true });
}
Comment thread
PavelSafronov marked this conversation as resolved.
Comment thread
PavelSafronov marked this conversation as resolved.

if (
topology.description.type === TopologyType.Sharded ||
operationError.hasErrorLabel(MongoErrorLabel.SystemOverloadedError)
Expand Down
129 changes: 129 additions & 0 deletions test/spec/client-backpressure/backpressure-connection-checkin.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,129 @@
{
"description": "tests that connections are returned to the pool on retry attempts for overload errors",
"schemaVersion": "1.3",
"runOnRequirements": [
{
"minServerVersion": "4.4",
"topologies": [
"replicaset",
"sharded",
"load-balanced"
]
}
],
"createEntities": [
{
"client": {
"id": "client",
"useMultipleMongoses": false,
"observeEvents": [
"connectionCheckedOutEvent",
"connectionCheckedInEvent"
]
}
},
{
"client": {
"id": "fail_point_client",
"useMultipleMongoses": false
}
},
{
"database": {
"id": "database",
"client": "client",
"databaseName": "backpressure-connection-checkin"
}
},
{
"collection": {
"id": "collection",
"database": "database",
"collectionName": "coll"
}
}
],
"tests": [
{
"description": "overload error retry attempts return connections to the pool",
"operations": [
{
"name": "failPoint",
"object": "testRunner",
"arguments": {
"client": "fail_point_client",
"failPoint": {
"configureFailPoint": "failCommand",
"mode": "alwaysOn",
"data": {
"failCommands": [
"find"
],
"errorLabels": [
"RetryableError",
"SystemOverloadedError"
],
"errorCode": 2
}
}
}
},
{
"name": "find",
"object": "collection",
"arguments": {
"filter": {}
},
"expectError": {
"isError": true,
"isClientError": false
}
}
],
"expectEvents": [
{
"client": "client",
"eventType": "cmap",
"events": [
{
"connectionCheckedOutEvent": {}
},
{
"connectionCheckedInEvent": {}
},
{
"connectionCheckedOutEvent": {}
},
{
"connectionCheckedInEvent": {}
},
{
"connectionCheckedOutEvent": {}
},
{
"connectionCheckedInEvent": {}
},
{
"connectionCheckedOutEvent": {}
},
{
"connectionCheckedInEvent": {}
},
{
"connectionCheckedOutEvent": {}
},
{
"connectionCheckedInEvent": {}
},
{
"connectionCheckedOutEvent": {}
},
{
"connectionCheckedInEvent": {}
}
]
}
]
}
]
}
67 changes: 67 additions & 0 deletions test/spec/client-backpressure/backpressure-connection-checkin.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,67 @@
description: tests that connections are returned to the pool on retry attempts for overload errors
schemaVersion: "1.3"
runOnRequirements:
- minServerVersion: "4.4"
topologies:
- replicaset
- sharded
- load-balanced
createEntities:
- client:
id: client
useMultipleMongoses: false
observeEvents:
- connectionCheckedOutEvent
- connectionCheckedInEvent
- client:
id: fail_point_client
useMultipleMongoses: false
- database:
id: database
client: client
databaseName: backpressure-connection-checkin
- collection:
id: collection
database: database
collectionName: coll
tests:
- description: overload error retry attempts return connections to the pool
operations:
- name: failPoint
object: testRunner
arguments:
client: fail_point_client
failPoint:
configureFailPoint: failCommand
mode: alwaysOn
data:
failCommands:
- find
errorLabels:
- RetryableError
- SystemOverloadedError
errorCode: 2
- name: find
object: collection
arguments:
filter: {}
expectError:
isError: true
isClientError: false
expectEvents:
- client: client
eventType: cmap
events:
- connectionCheckedOutEvent: {}
- connectionCheckedInEvent: {}
- connectionCheckedOutEvent: {}
- connectionCheckedInEvent: {}
- connectionCheckedOutEvent: {}
- connectionCheckedInEvent: {}
- connectionCheckedOutEvent: {}
- connectionCheckedInEvent: {}
- connectionCheckedOutEvent: {}
- connectionCheckedInEvent: {}
- connectionCheckedOutEvent: {}
- connectionCheckedInEvent: {}

Loading