test(NODE-7160): migrate node-mongodb-native/test/unit/assorted tests

[PavelSafronov]

Description

Summary of Changes

Migrating node-mongodb-native/test/unit/assorted driver callback API style tests to promises.

Notes for Reviewers

Repro/test steps:

1. comment out line 229 in test/mongodb.ts (this disables MongoDB legacy)
2. run npm run check:unit
3. note failures in test/unit/assorted/sessions_client.test.ts
4. apply fix
5. run npm run check:unit
6. note that none of the failures are coming from test/unit/assorted/sessions_client.test.ts
7. uncomment line 229 in test/mongodb.ts
8. run npm run check:unit
9. note all tests are passing

What is the motivation for this change?

https://jira.mongodb.org/browse/NODE-4979

We want to modify all tests to no longer use callbacks as the driver is a promise only API now. This is a requirement for deprecating the legacy driver.

Double check the following

• Lint is passing (npm run check:lint)
• Self-review completed using the steps outlined here
• PR title follows the correct format: type(NODE-xxxx)[!]: description
  • Example: feat(NODE-1234)!: rewriting everything in coffeescript
• Changes are covered by tests
• New TODOs have a related JIRA ticket

[baileympearson]

From the test refactor ticket:

Update the client import in each updated file to use src instead of legacy

Can we also update each file in this directory to import from src, instead of from ../../mongodb?

Additionally, going forward, can we put any JS->TS conversions into their own commit? That helps with review, because you can then view the diff on subsequent commits to see the substantive changes. The diff in this PR is unhelpful

[dariakp]

@PavelSafronov Just a note that I updated the conventional commit tag in the PR title to "test". We reserve "fix" for bug fixes of source code.

[PavelSafronov]

@baileympearson Thanks for the comments here and offline!

As discussed, we are removing one of the lint rules that blocks importing of src/ files. That removal resulted in the removal of a lot of eslint suppressions (after running npm run fix:eslint), so that's why we're seeing so many changes outside of node-mongodb-native/test/unit/assorted dir.

Aside from that, the node-mongodb-native/test/unit/assorted changes have been mostly to update imports and rewrite some of the callback-based tests to use promises.

[baileympearson]

Just a few small comments. Looks good! And thanks for removing our lint rule that we no longer need.

[baileympearson]

Failing tests are also failing on other branches. LGTM