Add tripwire tests for the RTAS policy merge (stacked on #652) - #18
Closed
mkuchenbecker wants to merge 1 commit into
Closed
Add tripwire tests for the RTAS policy merge (stacked on #652)#18mkuchenbecker wants to merge 1 commit into
mkuchenbecker wants to merge 1 commit into
Conversation
Guard mergePolicies against a new policy plane being added to Policies without teaching the RTAS merge to carry it forward. A behavioral test populates every object plane on the existing table, merges a request that omits them, and reflectively asserts each survives; a structural test pins the exact set of Policies fields so any add/rename/remove (including a primitive) trips it. Co-authored-by: Copilot <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stacked on linkedin#652. Adds tripwire tests that guard the RTAS policy merge against a future policy plane
being added to
Policieswithout updatingmergePoliciesto carry it forward (which wouldreintroduce the silent policy-drop this PR series fixes).
omits them, and reflectively assert each plane survives — a new plane that
mergePoliciesforgetscomes back
nulland fails with a pointed message.Policiesfield names, so any add / remove / rename(including a primitive the behavioral test can't observe) trips the test and forces a conscious
merge update.
Testing Done
RtasPolicyMergeTripwireTest(both tests) — pass.mergePoliciesfails the behavioral test with"RTAS policy merge dropped Policies.". Spotless clean.