Skip to content

Commit 122e4e3

Browse files
Fix issue hanging the Build_CMakeTools call with no preset selected (#4860)
* Fix issue hanging the Build_CMakeTools call with no preset selected * no variable
1 parent ae3da88 commit 122e4e3

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -87,6 +87,7 @@ Bug Fixes:
8787
- Fix issue with hover provider not checking for undefined. [#4812](https://github.com/microsoft/vscode-cmake-tools/issues/4812)
8888
- Fix bug in which CTest is unable to run large amount of tests in parallel due to regex exceeding command line length limits [#4829](https://github.com/microsoft/vscode-cmake-tools/issues/4829) [@theuke](https://github.com/theuke)
8989
- Fix malformed devcontainer.json used for working with GitHub Codespaces and similar environments [#4588](https://github.com/microsoft/vscode-cmake-tools/pull/4588) [@kaladron](https://github.com/kaladron)
90+
- Fix hang in `buildWithResult` tool when there isn't a configure preset selected. [#4857](https://github.com/microsoft/vscode-cmake-tools/issues/4857)
9091

9192
## 1.22.28
9293

src/cmakeProject.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1994,9 +1994,9 @@ export class CMakeProject {
19941994
}
19951995
}
19961996
} else if (!this.configurePreset) {
1997-
await vscode.window.showErrorMessage(localize('cannot.configure.no.config.preset', 'Cannot configure: No configure preset is active for this CMake project'));
1997+
void vscode.window.showErrorMessage(localize('cannot.configure.no.config.preset', 'Cannot configure: No configure preset is active for this CMake project'));
19981998
log.debug(localize('no.preset.abort', 'No preset selected. Abort configure'));
1999-
return { exitCode: -1, resultType: ConfigureResultType.Other };
1999+
return { exitCode: -1, resultType: ConfigureResultType.Other, stderr: 'Cannot configure: No configure preset is active for this CMake project' };
20002000
}
20012001
const consumer = new CMakeOutputConsumer(this.sourceDir, cmakeLogger);
20022002
const result = await cb(consumer);

0 commit comments

Comments
 (0)