Fix: CMake: Set Build Target shows all targets when using presets (#4671)

* Initial plan

* Fix CMake: Set Build Target command not showing available targets with presets

When using CMake Presets with build presets that define a targets field,
the showTargetSelector() method was returning early and only showing
preset-defined targets instead of all available CMake targets.

This fix removes the early return and instead adds the [Targets In Preset]
option to the beginning of the full target list when appropriate. Users can
now see and select from all available CMake targets, while still having the
option to use [Targets In Preset] to build the preset-defined targets.

Fixes #4509

Co-authored-by: hanniavalera <[email protected]>

---------

Co-authored-by: copilot-swe-agent[bot] <[email protected]>
Co-authored-by: hanniavalera <[email protected]>

Author: Copilot

CHANGELOG.md

@@ -73,6 +73,7 @@ Bug Fixes:
 - Fix build/debug/launch target selection not working when `CMAKE_BUILD_TYPE` is not set in the preset or is changed in CMakeLists.txt. [#4219](https://github.com/microsoft/vscode-cmake-tools/issues/4219)
 - Fix CMake script path links not working in CHS/CSY/FRA/PLK locales due to localized quotes. [#4383](https://github.com/microsoft/vscode-cmake-tools/issues/4383)
 - Fix user-level tasks defined in `~/.config/Code/User/tasks.json` causing infinite spinner. [#4659](https://github.com/microsoft/vscode-cmake-tools/pull/4659)
+- Fix `CMake: Set Build Target` command not showing available targets when using presets with defined targets. [#4509](https://github.com/microsoft/vscode-cmake-tools/issues/4509)
 - Fix `cmake.compileFile` failing to find compilation info when using presets without `CMAKE_EXPORT_COMPILE_COMMANDS`. [#4484](https://github.com/microsoft/vscode-cmake-tools/issues/4484)
 - Fix "Copy Value" in CMake debugger copying variable name instead of value. [#4551](https://github.com/microsoft/vscode-cmake-tools/issues/4551)
 - cmakeDriver: Fixes getCompilerVersion by using compilerPath instead of compilerName. [#4647](https://github.com/microsoft/vscode-cmake-tools/pull/4647) [@lygstate](https://github.com/lygstate)

src/cmakeProject.ts

@@ -2408,19 +2408,17 @@ export class CMakeProject {
             return '';
         }
 
-        if (this.useCMakePresets && this.buildPreset?.targets) {
-            const targets = [this.targetsInPresetName];
-            targets.push(...(util.isString(this.buildPreset.targets) ? [this.buildPreset.targets] : this.buildPreset.targets));
-            const sel = await vscode.window.showQuickPick(targets, { placeHolder: localize('select.active.target.tooltip', 'Select the default build target') });
-            return sel || null;
-        }
-
         if (!drv.targets.length) {
             return await vscode.window.showInputBox({ prompt: localize('enter.target.name', 'Enter a target name') }) || null;
         } else {
             const folders: string[] = [];
             const itemsGroup: (RichTarget | NamedTarget | FolderTarget)[] = [];
 
+            // Add special "[Targets In Preset]" option when using presets with defined targets
+            if (this.useCMakePresets && this.buildPreset?.targets) {
+                itemsGroup.push({ type: 'named', name: this.targetsInPresetName });
+            }
+
             // group the data
             drv.uniqueTargets.forEach((t) => {
                 switch (t.type) {