Fix artifacts-helper non-root temp file append#114
Merged
markphip merged 2 commits intomicrosoft:mainfrom Apr 28, 2026
Merged
Conversation
Stream the root-created aliases block into the non-root append command over stdin so the remote user does not need read access to the mktemp file. Add a non-root install regression scenario and bump artifacts-helper to 3.0.9. Fixes microsoft#112 Co-authored-by: Copilot <[email protected]>
Contributor
|
This PR is better than mine #113 but I think my fix makes more sense. Can you implement it since it is in your fork? |
Make the generated aliases temp file readable before appending it as the non-root remote user. This keeps the installer flow aligned with the existing implementation while fixing the non-root permission failure. Co-authored-by: Copilot <[email protected]>
Member
Author
|
Done |
markphip
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #112
Validation
jq empty test/artifacts-helper/scenarios.json src/artifacts-helper/devcontainer-feature.jsonbash -n src/artifacts-helper/install.sh test/artifacts-helper/test_non_root_install.sh test/artifacts-helper/test_shim_integration.shgit diff --checkchmod a+rapproach succeeds