Conversation
…n ALIASES_BLOCK Agent-Logs-Url: https://github.com/microsoft/codespace-features/sessions/d5a37724-4cc0-4c89-878a-02399bf66982 Co-authored-by: markphip <[email protected]>
Agent-Logs-Url: https://github.com/microsoft/codespace-features/sessions/d5a37724-4cc0-4c89-878a-02399bf66982 Co-authored-by: markphip <[email protected]>
Copilot
AI
changed the title
[WIP] Fix artifacts-helper's install.sh to install shims properly
fix(artifacts-helper): restore shim installation into shell rc files
Apr 27, 2026
markphip
approved these changes
Apr 27, 2026
abdurriq
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs introduced in late 2025 caused
install.shto silently skip writing shell function shims into.bashrc/.zshrc, leaving tools likenpmas plain executables rather than intercepted functions — causing 401 auth failures against Azure Artifacts feeds.Root causes
COMMA_SEP_TARGET_FILESwas never set to"DEFAULT", so the guardif [ "${COMMA_SEP_TARGET_FILES}" = "DEFAULT" ]was always false and target rc files were never populated.\ninside a bash double-quoted+=doesn't produce a real newline, so all function definitions concatenated into one line and were unparseable as shell functions.Changes
src/artifacts-helper/install.shCOMMA_SEP_TARGET_FILES="${TARGETFILES:-"DEFAULT"}"before the default-resolution block"...\n"→"..."$'\n'test/artifacts-helper/test_shim_integration.sh/etc/bash.bashrcand each appears at the start of its own line