Skip to content

Make an error message related to the PropertyDecorator kinder#61637

Closed
o-m12a wants to merge 2 commits intomicrosoft:mainfrom
o-m12a:make-property-decorator-error-message-kinder
Closed

Make an error message related to the PropertyDecorator kinder#61637
o-m12a wants to merge 2 commits intomicrosoft:mainfrom
o-m12a:make-property-decorator-error-message-kinder

Conversation

@o-m12a
Copy link
Copy Markdown
Contributor

@o-m12a o-m12a commented May 1, 2025

Fixes #4534

  • There is an associated issue in the Backlog milestone (required)
  • Code is up-to-date with the main branch
  • You've successfully run hereby runtests locally
  • There are new or updated unit tests validating the change

What I did

  • make some interfaces give and return DiagnosticAndArguments instead of DiagnosticMessage
  • improve the error message as mentioned at #4534 (comment)

@typescript-bot typescript-bot added the For Backlog Bug PRs that fix a backlog bug label May 1, 2025
@o-m12a
Copy link
Copy Markdown
Contributor Author

o-m12a commented May 1, 2025

@o-m12a please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@microsoft-github-policy-service agree 👍

@o-m12a
Copy link
Copy Markdown
Contributor Author

o-m12a commented May 1, 2025

@microsoft-github-policy-service agree

@o-m12a o-m12a marked this pull request as ready for review May 1, 2025 04:42
@RyanCavanaugh
Copy link
Copy Markdown
Member

The error message today is much better than the error was when the original issue was logged. I don't think the additional complexity this PR requires is needed to improve the message any further.

@microsoft microsoft locked as resolved and limited conversation to collaborators Jan 20, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

For Backlog Bug PRs that fix a backlog bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve error message for decorator type mismatches

3 participants