[SPIR-V] Fix counter in direct return stmt#8413
Merged
Keenuts merged 1 commit intomicrosoft:mainfrom Apr 29, 2026
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
There is a logic to create counter variables, and find them
from a source expression.
For return statements, we were first looking for the referenced
counter before dealing with the RHS of the expression: the call.
The fact that it worked so far was just luck:
- if the function decl was handled/seen before the return statement,
the counter variable association was handled.
But in case of a direct return, this was not the case.
Fixes microsoft#8215
s-perron
approved these changes
Apr 29, 2026
Collaborator
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a logic to create counter variables, and find them from a source expression.
For return statements, we were first looking for the referenced counter before dealing with the RHS of the expression: the call. The fact that it worked so far was just luck:
Fixes #8215