No-op: DxilCounters.cpp copy issue already fixed by #8296#8411
Closed
No-op: DxilCounters.cpp copy issue already fixed by #8296#8411
Conversation
Copilot
AI
changed the title
[WIP] Fix DXILCounters.cpp copy issue when HLSL_COPY_GENERATED_SOURCES is set
No-op: DxilCounters.cpp copy issue already fixed by #8296
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DxilCounters.cppwas not being copied whenHLSL_COPY_GENERATED_SOURCES=1, causing it to drift from its generated form.Investigation
Root cause:
add_hlsl_hctgenincmake/modules/HCT.cmakeregistered the per-file custom target asadd_custom_target(${mode} ...). BecauseDxilCountersis used as themodefor bothinclude/dxc/DXIL/DxilCounters.handlib/DXIL/DxilCounters.cpp, the second registration collided with the first, and the.cpptarget was never wired intoHCTGen.This was already fixed on
mainby commit745a694e5(PR #8296), which:HCT.cmake:add_hlsl_hctgen(DxilCounters OUTPUT DxilCounters.cpp CODE_TAG)entry inlib/DXIL/CMakeLists.txt.tools/clang/lib/Sema/CMakeLists.txtto depend onDxilIntrinsicTables_h(the new naming).lib/DXIL/DxilCounters.cppwith its current correct content.Changes in this PR
None. Verified that:
745a694e5are present in the current branch.hctgen.py DxilCounters+clang-formaton bothlib/DXIL/DxilCounters.cppandinclude/dxc/DXIL/DxilCounters.hproduces output that exactly matches the committed files — no drift.The referenced issue can be closed as already resolved by #8296.