Skip to content

Fix building when SPIRV is disabled #8408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
damyanp merged 2 commits into from
Apr 27, 2026
+6 −0
Merged

Fix building when SPIRV is disabled #8408

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5c6417a
Fix building when SPIRV is disabled.
damyanp Apr 26, 2026
3dd1647
chore: autopublish 2026-04-26T01:56:01Z
github-actions[bot] Apr 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions tools/clang/lib/Sema/SemaHLSL.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7443,6 +7443,7 @@ bool HLSLExternalSource::MatchArguments(
if (i == 0 &&
(builtinOp == hlsl::IntrinsicOp::IOP_Vkreinterpret_pointer_cast ||
builtinOp == hlsl::IntrinsicOp::IOP_Vkstatic_pointer_cast)) {
#ifdef ENABLE_SPIRV_CODEGEN
if (functionTemplateTypeArg.isNull()) {
badArgIdx = std::min(badArgIdx, i);
continue;
Expand Down Expand Up @@ -7482,6 +7483,11 @@ bool HLSLExternalSource::MatchArguments(
pNewType = m_context->getTemplateSpecializationType(
TemplateName(m_vkBufferPointerTemplateDecl), TemplateArgs, 2,
m_context->getTypeDeclType(Spec));
#else
// The IOP_Vk* opcodes are only reachable when ENABLE_SPIRV_CODEGEN is
// defined.
llvm_unreachable("vk:: pointer cast intrinsics require SPIR-V codegen");
#endif // ENABLE_SPIRV_CODEGEN
} else {
badArgIdx = std::min(badArgIdx, i);
}
Expand Down