Add defensive checks for declToIndex entries#8401
Open
tcorringham wants to merge 1 commit intomicrosoft:mainfrom
Open
Add defensive checks for declToIndex entries#8401tcorringham wants to merge 1 commit intomicrosoft:mainfrom
tcorringham wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Check the variable is in the declToIndex map before calling reportUse() for that variable or marking it as Initialized. HLSL out parameters or local variables from template instantiations may not be in the declToIndex map in the current DeclContext, which can lead to asserts when they are enabled, or the use of unitialized memory otherwise. Fixes microsoft#5293 Fixes microsoft#8310
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Check the variable is in the declToIndex map before calling reportUse() for that variable or marking it as Initialized.
HLSL out parameters or local variables from template instantiations may not be in the declToIndex map in the current DeclContext, which can lead to asserts when they are enabled, or the use of unitialized memory otherwise.
Fixes #5293
Fixes #8310