-
Notifications
You must be signed in to change notification settings - Fork 852
Update versioning for SM 6.10 2605 preview release #8395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tex3d
merged 5 commits into
microsoft:release-preview-1.10.2605
from
tex3d:update-preview-version
Apr 22, 2026
+14
−7
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0dd7d61
Update versioning for 2605 preview release
tex3d 54c62d7
Change minor back to 9 and fix rev
tex3d 2276cf5
Back out ReleaseNotes.md change for separate PR to address
tex3d e3f2ffb
gen_version.py: use preview_minor to override release minor for previ…
tex3d 75fa7ad
add preview_minor to latest-release.json
tex3d File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure this it intended but calling out that its showing 1.10 just in case it wasn't
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, good point. I'm not sure how extensive the impact of the json version is, so I should update these back to 9 for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, but I'm not sure I want to change the binary file versions this way...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to update the version in the json for the preview, but that was before we drove a
highest_released_minorfrom that value. I think it makes sense to leave the json, since it's not the released version that's incremented, but then to also update the file version for the preview. But since there have been changes to build scripts/pipelines and versioning components, I don't know for sure whether the version.inc file is even used for the official release build, or if a different one is generated from the json dynamically instead. I need to double-check some things.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, my latest push adds a preview_minor to the version info in latest-release.json to support overriding the minor version in gen_version.py for preview releases without disturbing the highest released DXIL version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could likely merge such a change to main and extend this mechanism to avoid manually updating the DXIL version in hctdb_instrhelp.py separately. The
preview_minorwould always be the highest supported experimental/preview version, and any version higher than the released minor version gets the PREVIEW hash from validation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, I don't think we do that here but getting that into main would be a nice QOL change
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What I said here wouldn't work properly for main yet, but we could think about what would work and adjust accordingly.