Skip to content

[SM6.10][Bugfix][HLK] Only define SDK consts when missing #8341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
V-FEXrt merged 2 commits into from
Apr 6, 2026
Merged

[SM6.10][Bugfix][HLK] Only define SDK consts when missing #8341

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e8b0d4
[SM6.10][Bugfix][HLK] Only define SM6.10 when not provided
V-FEXrt Apr 6, 2026
48ab549
Missed some defines
V-FEXrt Apr 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions tools/clang/unittests/HLSLExec/HlslExecTestUtils.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,11 @@
#include "ShaderOpTest.h"
#include "dxc/Support/dxcapi.use.h"

// D3D_SHADER_MODEL_6_10 is not yet in the released Windows SDK.
// Define locally so the tests can target SM 6.10.
// Once the public SDK ships with this, a compile break (redefinition error)
// will signal that this local definition should be removed.
// Define SM6.10 only in the SDK versions where it is not present. This should
// be removed once widely supported.
#if defined(D3D12_PREVIEW_SDK_VERSION) && D3D12_PREVIEW_SDK_VERSION < 720
static const D3D_SHADER_MODEL D3D_SHADER_MODEL_6_10 = (D3D_SHADER_MODEL)0x6a;
#endif

// Local highest shader model known to DXC. Update this when adding support
// for new shader models. Unlike D3D_HIGHEST_SHADER_MODEL from the SDK,
Expand Down
Loading