[SM6.10][LinAlg][HLK] Small test cleanups#8295
Merged
V-FEXrt merged 8 commits intomicrosoft:mainfrom Mar 26, 2026
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
V-FEXrt
commented
Mar 25, 2026
Comment on lines
+736
to
+741
| std::wstringstream LogFlags; | ||
| LogFlags << L"Compiling with flags:"; | ||
| for (const auto &A : WArgStorage) { | ||
| WArgPtrs.push_back(A.c_str()); | ||
| LogFlags << L" " << A; | ||
| } |
Collaborator
Author
There was a problem hiding this comment.
Note that this bit of code was also edited, not just moved
damyanp
approved these changes
Mar 25, 2026
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
LGTMbutithinkitisnicetohavesomespacingtomakeiteasiertoreadthings
alsepkow
reviewed
Mar 25, 2026
Co-authored-by: Damyan Pepper <[email protected]>
Co-authored-by: Damyan Pepper <[email protected]>
damyanp
requested changes
Mar 26, 2026
V-FEXrt
commented
Mar 26, 2026
Comment on lines
-201
to
-203
| WEX::TestExecution::SetVerifyOutput VerifySettings( | ||
| WEX::TestExecution::VerifyOutputSettings::LogOnlyFailures); | ||
|
|
Collaborator
Author
There was a problem hiding this comment.
we added this to the class above so it shouldn't be needed here
damyanp
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses outstanding cleanup requests from the initial LinAlg exec test PR