[SM6.10] Make DxilStructAnnotation aware of target types#8282
Merged
hekota merged 5 commits intomicrosoft:mainfrom Mar 26, 2026
Merged
[SM6.10] Make DxilStructAnnotation aware of target types#8282hekota merged 5 commits intomicrosoft:mainfrom
hekota merged 5 commits intomicrosoft:mainfrom
Conversation
damyanp
approved these changes
Mar 24, 2026
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
A few nits, but I think it's mostly around following existing style in this file, which seems somewhat appropriate given the nature of this change.
damyanp
approved these changes
Mar 24, 2026
bogner
approved these changes
Mar 25, 2026
Comment on lines
+895
to
+898
| if (Ty->isPointerTy()) | ||
| Ty = Ty->getPointerElementType(); | ||
| if (Ty->isArrayTy()) | ||
| Ty = Ty->getArrayElementType(); |
Collaborator
There was a problem hiding this comment.
Is it deliberate that this only handles pointers to arrays, and not arrays of pointers or other more complicated nestings?
Member
Author
There was a problem hiding this comment.
I think so. We don't support array of pointers to resources or target types.
V-FEXrt
approved these changes
Mar 25, 2026
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
V-FEXrt
reviewed
Mar 26, 2026
V-FEXrt
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
DxilStructAnnotationto be aware of target types. Otherwise the annotation would declare a struct with a single LinAlg Matrix type as empty, leading to invalid codegen.Declaration names match the style of the surrounding code.
Fixes #8279