Skip to content

[SEMA] Don't emit an error for sizeof an enum. #7449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-perron merged 2 commits into from
May 16, 2025
Merged

[SEMA] Don't emit an error for sizeof an enum. #7449

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a6441e
[SEMA] Don't emit an error for sizeof an enum.
s-perron May 12, 2025
d8e8f6f
Add AST test.
s-perron May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/clang/lib/AST/HlslTypes.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ bool IsHLSLNumericOrAggregateOfNumericType(clang::QualType type) {
} else if (type->isArrayType()) {
return IsHLSLNumericOrAggregateOfNumericType(
QualType(type->getArrayElementTypeNoTypeQual(), 0));
} else if (type->isEnumeralType()) {
return true;
}

// Chars can only appear as part of strings, which we don't consider numeric.
Expand Down
31 changes: 31 additions & 0 deletions tools/clang/test/CodeGenSPIRV/enum_sizeof.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
// RUN: %dxc -T cs_6_0 -E main -fcgl %s -spirv | FileCheck %s

enum E1 : uint64_t
{
v1 = 0,
};

enum E2 : uint32_t
{
v2 = 0,
};

struct S {
E1 e1;
E2 e2;
};

RWBuffer<int> b;

[numthreads(128, 1, 1)]
void main()
{
// CHECK: OpImageWrite {{%.*}} %uint_0 %int_8 None
b[0] = sizeof(E1);

// CHECK: OpImageWrite {{%.*}} %uint_1 %int_4 None
b[1] = sizeof(E2);

// CHECK: OpImageWrite {{%.*}} %uint_2 %int_16 None
b[2] = sizeof(S);
}