Skip to content

[SPIRV] Add warning for initialized globals #7448

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-perron merged 2 commits into from
May 15, 2025
Merged

[SPIRV] Add warning for initialized globals #7448

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
69de064
[SPIRV] Add warning for initialized globals
s-perron May 12, 2025
4358d0f
Remove unnecessary new line.
s-perron May 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions tools/clang/lib/SPIRV/SpirvEmitter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2021,6 +2021,11 @@ void SpirvEmitter::doVarDecl(const VarDecl *decl) {
// variables) belongs to the Function storage class.
if (isExternalVar(decl)) {
var = declIdMapper.createExternVar(decl);

Comment thread
s-perron marked this conversation as resolved.
Outdated
if (decl->hasInit()) {
emitWarning("Initializer of external global will be ignored",
decl->getLocation());
}
} else {
// We already know the variable is not externally visible here. If it does
// not have local storage, it should be file scope variable.
Expand Down
19 changes: 19 additions & 0 deletions tools/clang/test/CodeGenSPIRV/groupshared.init.warning.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
// RUN: %dxc -T cs_6_0 -E main -spirv %s 2>&1 | FileCheck %s

groupshared uint testing = 0;

[numthreads(64, 1, 1)]
void main(uint local_thread_id_flat : SV_GroupIndex) {

InterlockedAdd(testing, 1);
GroupMemoryBarrierWithGroupSync();

if (local_thread_id_flat == 0) {
if (testing > 64) {
printf("testing is %u wtf", testing);
}
}
}

// CHECK: warning: Initializer of external global will be ignored
// CHECK-NEXT: groupshared uint testing = 0;