[CoopVec] Add multi-layer support for ExecutionTest::CoopVec_Mul#7436
Closed
jholewinski-nv wants to merge 6 commits intomicrosoft:staging-sm6.9from
Closed
[CoopVec] Add multi-layer support for ExecutionTest::CoopVec_Mul#7436jholewinski-nv wants to merge 6 commits intomicrosoft:staging-sm6.9from
jholewinski-nv wants to merge 6 commits intomicrosoft:staging-sm6.9from
Conversation
damyanp
reviewed
May 7, 2025
damyanp
approved these changes
May 7, 2025
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Broad strokes LGTM. I had one question in the comments.
Member
|
This has all been rolled into #7437 now, making this one out of date. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds support for NumLevels=2 to verify functional correctness of multi-layer applications of CoopVec. This includes some cleanup work to make it easier to abstract out vectors and matrices in the test code.