Skip to content

[Internal] Remove dead fallthrough statement#7433

Merged
bob80905 merged 1 commit intomicrosoft:mainfrom
bob80905:fix_llvm_fallthrough
May 7, 2025
Merged

[Internal] Remove dead fallthrough statement#7433
bob80905 merged 1 commit intomicrosoft:mainfrom
bob80905:fix_llvm_fallthrough

Conversation

@bob80905
Copy link
Copy Markdown
Collaborator

@bob80905 bob80905 commented May 7, 2025

This PR removes a dead fallthrough statement after a switch-statement's case that is terminated by a break;
This needs to be removed, because the way linux builds dxc in our internal infrastructure, it errors when a dead fallthrough statement is detected.
For context, here is the relevant error:

ScalarReplAggregatesHLSL.cpp:2822:9: error: fallthrough annotation in unreachable code [-Werror,-Wimplicit-fallthrough]
        LLVM_FALLTHROUGH;
        ^
... DXC/include/llvm/Support/Compiler.h:224:26: note: expanded from macro 'LLVM_FALLTHROUGH'
#define LLVM_FALLTHROUGH [[fallthrough]]
                         ^
1 error generated.

@bob80905 bob80905 merged commit 556fc5b into microsoft:main May 7, 2025
13 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants