[SM6.9] Disable native vec deriv ops and expand testing#7432
Merged
pow2clk merged 1 commit intomicrosoft:mainfrom May 7, 2025
Merged
[SM6.9] Disable native vec deriv ops and expand testing#7432pow2clk merged 1 commit intomicrosoft:mainfrom
pow2clk merged 1 commit intomicrosoft:mainfrom
Conversation
Several intrinsics that were enabled for native vectors late got their testing removed as it expected scalarized forms. This adds tests for pow, modf, and abs in their native vector intrinsic forms. It removes native vector intrinsics for derivative operations as they require more scalarization removal due to their convergent markers and restores the scalarized testing for them. The 1024 size was removed from longvec-intrinsics as the verbose way that constant vectors are represented in the disassembly made the test take significantly longer.
pow2clk
changed the title
tex3d
approved these changes
May 6, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Yes please, looks good. Let's take this change into preview.
damyanp
approved these changes
May 6, 2025
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
Do the existing issues we have track the work required to re-enable them all again?
pow2clk
pushed a commit
to pow2clk/DirectXShaderCompiler
that referenced
this pull request
May 8, 2025
Several intrinsics that were enabled for native vectors late got their testing removed as it expected scalarized forms. This adds tests for pow, modf, and abs in their native vector intrinsic forms. It removes native vector intrinsics for derivative operations as they require more scalarization removal due to their convergent markers and restores the scalarized testing for them. The 1024 size was removed from longvec-intrinsics as the verbose way that constant vectors are represented in the disassembly made the test take significantly longer. (cherry picked from commit 231d648)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several intrinsics that were enabled for native vectors late got their testing removed as it expected scalarized forms. This adds tests for pow, modf, and abs in their native vector intrinsic forms. It removes native vector intrinsics for derivative operations as they require more scalarization removal due to their convergent markers and restores the scalarized testing for them. The 1024 size was removed from longvec-intrinsics as the verbose way that constant vectors are represented in the disassembly made the test take significantly longer.