Implement HLSL Diagnostics for LinAlg operations#7430
Merged
tex3d merged 51 commits intomicrosoft:mainfrom May 16, 2025
Merged
Conversation
anupamachandra
commented
May 5, 2025
anupamachandra
commented
May 5, 2025
Collaborator
Author
|
Couple of items left to do here:
|
Member
|
@anupamachandra - given that there's build errors and you have some more work planned, is it worth reviewing at this point? |
Collaborator
Author
Yes please. I'm working on the build errors and missed item is marked with a //FIXME. It think it'll be good to get some eyes on it to check if the PR meets expectations in terms of scope and if any big issues/gaps stand out. |
anupamachandra
commented
May 5, 2025
bob80905
reviewed
May 12, 2025
Collaborator
bob80905
left a comment
There was a problem hiding this comment.
A few nits / questions
llvm-beanz
reviewed
May 12, 2025
tex3d
reviewed
May 14, 2025
Contributor
tex3d
left a comment
There was a problem hiding this comment.
A couple comments on linalg.h API changes.
…ocalization issues
…g component class and update tests
Contributor
|
✅ With the latest revision this PR passed the Python code formatter. |
tex3d
approved these changes
May 16, 2025
bob80905
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements checks to validate the linalg builtin functions: __builtin_MatVecMul, __builtin_MatVecMulAdd, __builtin_OuterProductAccumulate and __builtin_VectorAccumulate. This includes:
Adds tests for all the above error checks.
Implements #7336