Fix logging of WARP location in ExecTests#7414
Closed
alsepkow wants to merge 1 commit intomicrosoft:mainfrom
Closed
Fix logging of WARP location in ExecTests#7414alsepkow wants to merge 1 commit intomicrosoft:mainfrom
alsepkow wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the logging message in the HLSL execution tests by correcting the format specifier used to print a wide string.
- Changed format specifier from %S to %ls so that the full module file path is printed correctly.
Comments suppressed due to low confidence (1)
tools/clang/unittests/HLSLExec/ExecutionTest.cpp:828
- Changing the format specifier from %S to %ls correctly matches the wide string type for szFullModuleFilePath. Ensure that similar logging calls throughout the codebase use the appropriate specifier.
L"WARP driver loaded from: %ls", szFullModuleFilePath));
damyanp
approved these changes
May 2, 2025
bob80905
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We changed the type of the string to fix a build related issue in another repo that ingests DXC source. When we did that we ended up with an incorrect format character for printing the string.
Fixed and verified locally that logging is working properly again.