Skip to content

Fix logging of WARP location in ExecTests#7414

Closed
alsepkow wants to merge 1 commit intomicrosoft:mainfrom
alsepkow:user/alsepkow/FixLoggingInExecTests
Closed

Fix logging of WARP location in ExecTests#7414
alsepkow wants to merge 1 commit intomicrosoft:mainfrom
alsepkow:user/alsepkow/FixLoggingInExecTests

Conversation

@alsepkow
Copy link
Copy Markdown
Contributor

@alsepkow alsepkow commented May 2, 2025

We changed the type of the string to fix a build related issue in another repo that ingests DXC source. When we did that we ended up with an incorrect format character for printing the string.

Fixed and verified locally that logging is working properly again.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the logging message in the HLSL execution tests by correcting the format specifier used to print a wide string.

  • Changed format specifier from %S to %ls so that the full module file path is printed correctly.
Comments suppressed due to low confidence (1)

tools/clang/unittests/HLSLExec/ExecutionTest.cpp:828

  • Changing the format specifier from %S to %ls correctly matches the wide string type for szFullModuleFilePath. Ensure that similar logging calls throughout the codebase use the appropriate specifier.
L"WARP driver loaded from: %ls", szFullModuleFilePath));

@alsepkow alsepkow closed this Jun 10, 2025
@alsepkow alsepkow deleted the user/alsepkow/FixLoggingInExecTests branch June 10, 2025 19:41
@github-project-automation github-project-automation Bot moved this from New to Done in HLSL Roadmap Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

5 participants