Don't pass through to DXIL.dll in DxcCreateInstance for CLSID_DxcValidator#7409
Merged
tex3d merged 1 commit intomicrosoft:mainfrom May 1, 2025
Merged
Conversation
…dator This change removes the code meant to pass through to DXIL.dll when creating a CLSID_DxcValidator object with DxcCreateInstance. Since the internal validator is now the default, and it will sign shaders, there is no reason to pass through to DXIL.dll when using DxcCreateInstance on DxCompiler.dll.
damyanp
approved these changes
May 1, 2025
Member
bob80905
approved these changes
May 1, 2025
Collaborator
|
Thanks Tex!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes the code meant to pass through to DXIL.dll when creating a CLSID_DxcValidator object with DxcCreateInstance.
Since the internal validator is now the default, and it will sign shaders, there is no reason to pass through to DXIL.dll when using DxcCreateInstance on DxCompiler.dll.
Testing will come with planned work to include the ability to globally override the default validator to external.