[SER] Validate HitObject::TraceRay|Invoke#7384
Merged
tex3d merged 5 commits intomicrosoft:mainfrom May 2, 2025
Merged
Conversation
Validate: HitObject_Invoke HitObject_TraceRay Rules: No undef params Resource handle must be AS SER implementation tracker: microsoft#7214
bob80905
reviewed
Apr 28, 2025
Collaborator
bob80905
left a comment
bob80905
left a comment
There was a problem hiding this comment.
Couple comments, and question:
Why not separate the tests so that one tests the validation in TraceRay and the other in Invoke?
bob80905
approved these changes
Apr 30, 2025
tex3d
approved these changes
Apr 30, 2025
bob80905
approved these changes
May 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate:
HitObject_Invoke
HitObject_TraceRay
Rules:
No undef params
Resource handle must be AS
SER implementation tracker: #7214