[SER] Validate HitObject accessors#7371
Merged
damyanp merged 5 commits intomicrosoft:mainfrom Apr 25, 2025
Merged
Conversation
Validate: HitObject_GeometryIndex HitObject_HitKind HitObject_InstanceID HitObject_InstanceIndex HitObject_IsHit HitObject_IsMiss HitObject_IsNop HitObject_LoadLocalRootTableConstant HitObject_ObjectRayDirection HitObject_ObjectRayOrigin HitObject_ObjectToWorld3x4 HitObject_PrimitiveIndex HitObject_RayFlags HitObject_RayTCurrent HitObject_RayTMin HitObject_SetShaderTableIndex HitObject_ShaderTableIndex HitObject_WorldRayDirection HitObject_WorldRayOrigin Rules: * No undef parameters (HitObject, RecordIndex, RootTableOffset) * row/col/component indices are constant and in-bounds * If constant, RootTableOffset % 4 == 0 SER implementation tracker: microsoft#7214
Collaborator
Author
|
damyanp
approved these changes
Apr 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validate:
HitObject_GeometryIndex
HitObject_HitKind
HitObject_InstanceID
HitObject_InstanceIndex
HitObject_IsHit
HitObject_IsMiss
HitObject_IsNop
HitObject_LoadLocalRootTableConstant
HitObject_ObjectRayDirection
HitObject_ObjectRayOrigin
HitObject_ObjectToWorld3x4
HitObject_PrimitiveIndex
HitObject_RayFlags
HitObject_RayTCurrent
HitObject_RayTMin
HitObject_SetShaderTableIndex
HitObject_ShaderTableIndex
HitObject_WorldRayDirection
HitObject_WorldRayOrigin
Rules:
SER implementation tracker: #7214