Skip to content

[SER] HitObject::FromRayQuery HLSL -> DXIL lowering#7370

Merged
tex3d merged 3 commits intomicrosoft:mainfrom
simoll:ser_hlslfromrq_patch
Apr 24, 2025
Merged

[SER] HitObject::FromRayQuery HLSL -> DXIL lowering#7370
tex3d merged 3 commits intomicrosoft:mainfrom
simoll:ser_hlslfromrq_patch

Conversation

@simoll
Copy link
Copy Markdown
Collaborator

@simoll simoll commented Apr 23, 2025

  • HLSL -> DXIL lowering
  • ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (#7214)

@simoll
[SER] HitObject::FromRayQuery HLSL -> DXIL lowering
90b3690 
* HLSL -> DXIL lowering
* ast, hlsl->dxil, dxilgen, and ScalarReplAggregatesHLSL tests

SER implementation tracker (microsoft#7214)
@simoll simoll mentioned this pull request Apr 23, 2025
Closed
41 tasks
@tex3d tex3d self-assigned this Apr 23, 2025
@tex3d tex3d moved this from New to In review in HLSL Roadmap Apr 23, 2025
tex3d
tex3d reviewed Apr 23, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@tex3d tex3d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple points for follow up:

  • parameter name/type in AST seems misaligned - might be a general static method issue
  • missing scalarrepl-param-hlsl case for overload without attributes.

Comment thread tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject_fromrayquery.hlsl
Comment thread tools/clang/test/SemaHLSL/hlsl/objects/HitObject/hitobject_fromrayquery.hlsl
Comment thread tools/clang/test/DXC/Passes/ScalarReplHLSL/hitobject_fromrayquery_scalarrepl.ll
@simoll simoll mentioned this pull request Apr 23, 2025
Closed
@simoll
Copy link
Copy Markdown
Collaborator Author

simoll commented Apr 23, 2025

A couple points for follow up:

  • parameter name/type in AST seems misaligned - might be a general static method issue
  • missing scalarrepl-param-hlsl case for overload without attributes.

damyanp
damyanp approved these changes Apr 24, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@damyanp damyanp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tex3d tex3d merged commit 624665f into microsoft:main Apr 24, 2025
12 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in HLSL Roadmap Apr 24, 2025
@simoll simoll deleted the ser_hlslfromrq_patch branch April 24, 2025 19:21
@damyanp damyanp removed this from HLSL Support Jun 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tex3d tex3d tex3d approved these changes

@damyanp damyanp damyanp approved these changes

@llvm-beanz llvm-beanz llvm-beanz approved these changes

Assignees

@tex3d tex3d

Labels

None yet

Projects

HLSL Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@simoll @tex3d @damyanp @llvm-beanz