Skip to content

[SPIRV] Remove patch decoration from gl_TessCoord (#7187) #7349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
s-perron merged 1 commit into from
Apr 16, 2025
Merged

[SPIRV] Remove patch decoration from gl_TessCoord (#7187) #7349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion tools/clang/lib/SPIRV/DeclResultIdMapper.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3522,7 +3522,8 @@ SpirvVariable *DeclResultIdMapper::createSpirvInterfaceVariable(
// Decorate with PerPrimitiveNV for per-primitive out variables.
spvBuilder.decoratePerPrimitiveNV(varInstr,
varInstr->getSourceLocation());
} else {
} else if (stageVar.getSemanticInfo().getKind() !=
hlsl::Semantic::Kind::DomainLocation) {
spvBuilder.decoratePatch(varInstr, varInstr->getSourceLocation());
}
}
Expand Down
1 change: 0 additions & 1 deletion tools/clang/test/CodeGenSPIRV/bezier.domain.hlsl2spv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,7 +96,6 @@ DS_OUTPUT BezierEvalDS( HS_CONSTANT_DATA_OUTPUT input,
// CHECK-NEXT: OpDecorate %in_var_TANVCORNER Patch
// CHECK-NEXT: OpDecorate %in_var_TANWEIGHTS Patch
// CHECK-NEXT: OpDecorate %gl_TessCoord BuiltIn TessCoord
// CHECK-NEXT: OpDecorate %gl_TessCoord Patch
// CHECK-NEXT: OpDecorate %gl_Position BuiltIn Position
// CHECK-NEXT: OpDecorate %in_var_BEZIERPOS Location 0
// CHECK-NEXT: OpDecorate %in_var_TANGENT Location 1
Expand Down
1 change: 0 additions & 1 deletion tools/clang/test/CodeGenSPIRV/semantic.domain-location.ds.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@
// CHECK-SAME: %gl_TessCoord

// CHECK: OpDecorate %gl_TessCoord BuiltIn TessCoord
// CHECK: OpDecorate %gl_TessCoord Patch

// CHECK: %gl_TessCoord = OpVariable %_ptr_Input_v3float Input

Expand Down
1 change: 0 additions & 1 deletion tools/clang/test/CodeGenSPIRV/spirv.interface.ds.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,6 @@ struct DsOut {
// CHECK: OpDecorateString %gl_PointSize UserSemantic "PSIZE"
// CHECK: OpDecorate %gl_TessCoord BuiltIn TessCoord
// CHECK: OpDecorateString %gl_TessCoord UserSemantic "SV_DomainLocation"
// CHECK: OpDecorate %gl_TessCoord Patch
// CHECK: OpDecorate %gl_TessLevelOuter BuiltIn TessLevelOuter
// CHECK: OpDecorateString %gl_TessLevelOuter UserSemantic "SV_TessFactor"
// CHECK: OpDecorate %gl_TessLevelOuter Patch
Expand Down
Loading