[spirv] Fixes vk::BufferPointer constructor expression construction.#7331
Merged
s-perron merged 2 commits intomicrosoft:mainfrom Apr 15, 2025
Merged
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
danbrown-amd
force-pushed
the
vk-buffer-pointer-from-uint
branch
from
5218056 to
b8087d7
Compare
Keenuts
approved these changes
Apr 15, 2025
Collaborator
Keenuts
left a comment
Keenuts
left a comment
There was a problem hiding this comment.
Thanks! just a small fix (use cast when a failed cast is a fatal error)
Co-authored-by: Nathan Gauër <[email protected]>
s-perron
approved these changes
Apr 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Constructors are now properly attached to the template class declaration instead of a specialization.
Closes #6489 (again).