[NFC] Standardize DxilValidation variable capitalization#7307
Merged
pow2clk merged 2 commits intomicrosoft:mainfrom Apr 4, 2025
Merged
[NFC] Standardize DxilValidation variable capitalization#7307pow2clk merged 2 commits intomicrosoft:mainfrom
pow2clk merged 2 commits intomicrosoft:mainfrom
Conversation
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Capitalize all the variables and rename a few in DxilValidation.cpp in keeping with https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly As this file was easily mistaken for applying to the golden rule: https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly it is at serious risk of receiving changes that will get hung up by requirements to follow the LLVM coding guidelines. This brings the cases where variable capitalization is not in line with the coding standards to avoid such pitfalls in the future.
pow2clk
changed the title
damyanp
previously approved these changes
Apr 3, 2025
Member
damyanp
left a comment
damyanp
left a comment
There was a problem hiding this comment.
This should help avoid ambiguity in the future.
We may want to consider waiting until some other changes in flight are complete (or we may not - we should check anyway!)
damyanp
approved these changes
Apr 3, 2025
tex3d
approved these changes
Apr 3, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
While I don't normally like wholesale reformatting changes like this, if it alleviates conflicts regarding the ambiguity of coding standards to apply for future changes, it's probably the lesser of evils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Capitalize all the variables and rename a few in DxilValidation.cpp in keeping with https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly
As this file was easily mistaken for applying to the golden rule: https://llvm.org/docs/CodingStandards.html#name-types-functions-variables-and-enumerators-properly it is at serious risk of receiving changes that will get hung up by requirements to follow the LLVM coding guidelines. This brings the cases where variable capitalization is not in line with the coding standards to avoid such pitfalls in the future.