-
Notifications
You must be signed in to change notification settings - Fork 851
Implementation of the CoopVec Inference and Training builtin intrinisics #7290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
damyanp
merged 97 commits into
microsoft:staging-sm6.9
from
anupamachandra:anupamac/coop-vec-5
Apr 18, 2025
Merged
Changes from 72 commits
Commits
Show all changes
97 commits
Select commit
Hold shift + click to select a range
75bb05e
Implement MulAdd, OutProdAcc, VecAcc lowering
anupamachandra 913c352
Add is signed parameters to the builtins
anupamachandra a6863d4
Change parameter names for better readability
anupamachandra 49bc4f0
Keeping parameter names accurate
anupamachandra 564689a
After clang-format
anupamachandra 6ec25f8
Fix variable names per LLVM coding standards
anupamachandra 3081f9e
chore: autopublish 2025-04-02T15:32:45Z
github-actions[bot] ae115e1
Update utils/hct/hctdb.py
anupamachandra 2b2656d
Change isSigned to isUnsigned
anupamachandra 5ef516a
Change HLSL intrinsic args from snake to upper camel case
anupamachandra 8c2d9ae
Name change for readability
anupamachandra df28777
Review Feedback: Add description for DXIL ops
anupamachandra a3bdc34
Fix generated files
anupamachandra f7fabd9
Add validation rules for DXIL ops
anupamachandra 50155c1
Unit test 1: Check linalg builtins for different shader stages: ps, v…
anupamachandra 9383c47
Replace std::set with linear search
anupamachandra 8df9520
Unit test: Check Intrinsic not enabled pre SM6.9
anupamachandra 8d44645
Unit tests: Check parameters of the Builtin calls
anupamachandra e70c140
Unit test: Outer Product Accumulate Multidimensional overload
anupamachandra 6c93071
Unit test: IR->IR Dxilgen test
anupamachandra ee9f3a2
Unit test ; Multidim overload for MatVecMul
anupamachandra 5d3f8b2
Simplify Matrix Layout check
anupamachandra d6c2806
Add checks to the HLSL source file linalg_builtins.hlsl
anupamachandra 7d74050
Updated RUN line and renamed test
simoll 724bebd
cleanup test
simoll 615824d
[nfc] Fix -Werror by removing braces
simoll 5b3b7ce
Fix debug field names for vectors > 4 elements
simoll 453d643
[nfc] auto-format hctdb.py
simoll e40b24d
Move sema test to SemaHLSL test folder (spurious CodeGenHashStability…
simoll 3d4b3ab
Merge branch 'staging-sm6.9' into anupamac/coop-vec-5
damyanp bc1082e
Revert SPIRV-Tools submodule to match staging-sm6.9 and main
damyanp 5455e64
Update lib/DxilValidation/DxilValidation.cpp
simoll c626bdb
Update lib/DxilValidation/DxilValidation.cpp
simoll da9f549
Update lib/DxilValidation/DxilValidation.cpp
simoll ebdc454
Update lib/DxilValidation/DxilValidation.cpp
simoll 6bb201a
Update lib/DxilValidation/DxilValidation.cpp
simoll 3816d7c
Update lib/DxilValidation/DxilValidation.cpp
simoll 0166d20
Update lib/DxilValidation/DxilValidation.cpp
simoll 3027487
Update lib/DxilValidation/DxilValidation.cpp
simoll a80ab65
Update lib/DxilValidation/DxilValidation.cpp
simoll 067bea3
Update lib/DxilValidation/DxilValidation.cpp
simoll 1dc4b2d
Update lib/DxilValidation/DxilValidation.cpp
simoll 3d06120
Update lib/DxilValidation/DxilValidation.cpp
simoll cde0954
Update lib/DxilValidation/DxilValidation.cpp
simoll 372c431
[nfc] Coding Standards changes
simoll 7633d12
Renamed params to isInput|OutputUnsigned and fixed description
simoll 9aa5df7
Explicitly assign numbers to ComponentType enum
simoll d2cbc3b
Move debug info fix into separate PR #7332
simoll df67c9f
move all tests to CodeGenDXIL/hlsl/intrinsics/linalg_builtin and make…
simoll e15eacb
Move linalg-builtins.ll test to DXC/Passes/DxilGen
simoll 9fcf8c7
Factored common code into function in check-shader-stages.hlsl
simoll 6eb36e4
Add test variations for different matVecMul parameter settings
simoll e310fd6
Add test with variations for matVecMulAdd
simoll dff8fba
Add HLSL -> HL checks for matVecMul
simoll 8c924ba
Add HLSL -> HL checks for matVecMulAdd
simoll 55d8fc7
update tests to not transpose RowMajor/ColumnMajor
simoll 5c61273
Diagnose unsigned<>type mismatches and transpose<>layout mismatch
simoll 5b190f0
Fix merge resolution for DXIL 1.9 opcode cap.
tex3d b0bcab8
Update lib/DxilValidation/DxilValidation.cpp
simoll 61607e7
Update lib/DxilValidation/DxilValidation.cpp
simoll 78a39c6
Update lib/DxilValidation/DxilValidation.cpp
simoll a54d4d0
Update lib/DxilValidation/DxilValidation.cpp
simoll 5e72dbf
Update lib/DxilValidation/DxilValidation.cpp
simoll 50e0b73
Update lib/DxilValidation/DxilValidation.cpp
simoll 441c4a4
Update lib/DxilValidation/DxilValidation.cpp
simoll 083f258
Update lib/DxilValidation/DxilValidation.cpp
simoll ede7bdb
Update lib/DxilValidation/DxilValidation.cpp
simoll 8675c40
Update lib/DxilValidation/DxilValidation.cpp
simoll 82ee147
Update lib/DxilValidation/DxilValidation.cpp
simoll 623f752
nfc: fix call after callee name change
simoll 5d4af66
remove opcode marker
simoll 5951621
nfc: s/\t/ /g + strip trailing wspace
simoll 70cdd13
some more s/\t/ /g
simoll 4d97b84
Add all params to test
simoll 8a96622
Merge remote-tracking branch 'ms/main' into coop-vec-5
tex3d 8ce1223
Merge remote-tracking branch 'ms/staging-sm6.9' into coop-vec-5
tex3d c636e6f
Update include/dxc/DXIL/DxilConstants.h
simoll 70a83af
Update utils/hct/hctdb.py
simoll 9cf0b99
Update utils/hct/hctdb.py
simoll 503d4b8
Repair after DXILMatrixLayout -> LinalgMatrixLayout name change
simoll 797d89c
Regen after attr change from 'None' -> 'ReadOnly'
simoll b8e4985
nfc: store output vector in tests to keep coopvec dxil ops alive
simoll 47c4f3f
Remove redundant tests (subsumed by multioverload versions)
simoll cc6cc27
CheckLinalgInterpretation for InMemory and InRegister type validation
simoll d344e73
Align test with spec: "Note: Only Optimal layouts can be used with fo…
simoll faa8f8f
Align test with spec: "Packed" type conversions are bitcasts to a sma…
simoll 41217f3
Fix DXIL OuterProductAccmulate param ordering (minterp, mlayout, mstr…
simoll 1b23b26
Multioverload OuterProductAccmuluate test (and remove redundant
simoll a3f76ef
nfc: autoformat
simoll 871694c
Merge remote-tracking branch 'ms/staging-sm6.9' into coop-vec-5
tex3d 791dff3
Update tests with new hl opcodes
tex3d d5f03f2
Remvoved MatrixLayout check for OuterProductAccumulate, updated DXIL …
anupamachandra f5a1a51
Update linalg_builtin.hlsl to intialize input vectors for outerproduc…
anupamachandra 1538453
Removed undefs and added named checks for resource handles in the lin…
anupamachandra 7cbe979
Update diagnostics per llvm coding guidelines
anupamachandra faf6df0
Missing trailing comma was bugging darker
anupamachandra 8782246
Fix linalg-builtins.hlsl file check: missing comma
anupamachandra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.