Add UUID compiler extension check on Clang#7286
Merged
llvm-beanz merged 1 commit intomicrosoft:mainfrom Apr 3, 2025
Merged
Conversation
Fixes microsoft#7248 Fix Clang Compilation on Linux without Microsoft Extensions enabled. ## Rationale Clang support depends on the `-fms-extensions` compiler flag. ([1](https://clang.llvm.org/docs/UsersManual.html#microsoft-extensions)) If enabled, the `_MSC_EXTENSIONS` macro is defined. ([2](https://github.com/llvm/llvm-project/blob/19a319667b567a26a20f9829a0ae7e6a5c259cba/clang/lib/Basic/Targets/OSTargets.cpp#L248) --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/microsoft/DirectXShaderCompiler/issues/7248?shareId=XXXX-XXXX-XXXX-XXXX).
llvm-beanz
approved these changes
Apr 1, 2025
Collaborator
llvm-beanz
left a comment
llvm-beanz
left a comment
There was a problem hiding this comment.
This change LGTM, and should allow clients of DXC to use Clang without the MS extensions enabled.
damyanp
approved these changes
Apr 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7248
Fix Clang Compilation on Linux without Microsoft extensions enabled.
Rationale
Clang support depends on the
-fms-extensionscompiler flag. [1]If enabled, the
_MSC_EXTENSIONSmacro is defined. [2]