[SER] MaybeReorderThread DXIL opcode and validation#7256
Merged
tex3d merged 8 commits intomicrosoft:mainfrom Apr 14, 2025
Merged
[SER] MaybeReorderThread DXIL opcode and validation#7256tex3d merged 8 commits intomicrosoft:mainfrom
tex3d merged 8 commits intomicrosoft:mainfrom
Conversation
- DXIL opcodes for MaybeReorderThread - Validator rules - DXV validation test (passing & expected failures) Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md DXC SER implementation tracker: microsoft#7214
CoherenceBits when NumBits != 0 / move tests to LitDXILValidation and update them
Collaborator
Author
|
Changed dxil validation rules in acc with microsoft/hlsl-specs#485
also updated passing and failing validation test cover those cases EDIT: |
llvm-beanz
approved these changes
Apr 11, 2025
Contributor
|
✅ With the latest revision this PR passed the Python code formatter. |
llvm-beanz
approved these changes
Apr 14, 2025
tex3d
reviewed
Apr 14, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
DXIL op is missing category and shader model, otherwise looks good.
tex3d
approved these changes
Apr 14, 2025
Contributor
tex3d
left a comment
tex3d
left a comment
There was a problem hiding this comment.
Looks good now, but I'm the last one who pushed changes, so it needs a new independent review.
llvm-beanz
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Specification: https://github.com/microsoft/hlsl-specs/blob/main/proposals/0027-shader-execution-reordering.md
DXC SER implementation tracker: #7214