Add support for KHR_compute_shader_derivatives#7249
Merged
s-perron merged 2 commits intomicrosoft:mainfrom Mar 26, 2025
Merged
Conversation
DirectxShaderCompiler already supports NV_compute_shader_derivatives which is functionality identical to KHR_compute_shader_derivatives The KHR extension will be used by default instead of the NV one following the same approach as the RT extension. We currently explain this in a comment in tools/clang/lib/SPIRV/FeatureManager.cpp FeatureManager::enabledByDefault. Check commit introducing RT for more info 04a84f0
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
Contributor
Author
|
@microsoft-github-policy-service agree company="Arm" |
s-perron
approved these changes
Mar 25, 2025
Collaborator
|
Thanks for fixing it. I don't know when I would have got it it. |
cassiebeckley
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for KHR_compute_shader_derivatives
NV_compute_shader_derivativeswhich is functionality identical toKHR_compute_shader_derivativestools/clang/lib/SPIRV/FeatureManager.cppFeatureManager::enabledByDefault.Fixes #7179